From: Lucas Correia Villa Real <lucasvr@gobolinux.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Antonino A. Daplas" <adaplas@gmail.com>
Subject: i810fb_blank
Date: Thu, 15 Dec 2005 16:14:44 -0200 [thread overview]
Message-ID: <200512151614.44766.lucasvr@gobolinux.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Hi!
While looking at i810fb_blank() on 2.4 and 2.6, I've seen that there's a
difference on how pwr mask is handled: 2.4 unsets the pwr bit on
FB_BLANK_VSYNC_SUSPEND and FB_BLANK_HSYNC_SUSPEND commands,
while 2.6 turns that bit on. Was that modification expected, or was it a
typo? The attached patch shows the code in question.
Thanks!
--
Lucas
powered by /dev/dsp
[-- Attachment #2: 2.6.14.3-i810-suspend.patch --]
[-- Type: text/x-diff, Size: 554 bytes --]
Signed-off-by: Lucas Correia Villa Real <lucasvr@gobolinux.org>
--- linux-2.6.14.3/drivers/video/i810/i810_main.c.orig 2005-12-03 16:44:06.000000000 -0200
+++ linux-2.6.14.3/drivers/video/i810/i810_main.c 2005-12-03 16:45:55.000000000 -0200
@@ -1359,12 +1359,12 @@ static int i810fb_blank (int blank_mode,
break;
case FB_BLANK_VSYNC_SUSPEND:
mode = STANDBY;
- pwr |= 1;
+ pwr &= ~1;
scr_off = OFF;
break;
case FB_BLANK_HSYNC_SUSPEND:
mode = SUSPEND;
- pwr |= 1;
+ pwr &= ~1;
scr_off = OFF;
break;
case FB_BLANK_POWERDOWN:
next reply other threads:[~2005-12-15 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 18:14 Lucas Correia Villa Real [this message]
2005-12-15 23:15 ` i810fb_blank Antonino A. Daplas
2005-12-16 3:55 ` i810fb_blank Lucas Correia Villa Real
2005-12-16 6:00 ` Antonino A. Daplas
2005-12-16 18:10 ` Lucas Correia Villa Real
2005-12-16 19:10 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512151614.44766.lucasvr@gobolinux.org \
--to=lucasvr@gobolinux.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).