* drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
@ 2005-03-22 19:53 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-03-22 19:53 UTC (permalink / raw)
To: adaplas; +Cc: linux-fbdev-devel, linux-kernel
The Coverity checker noticed that in the function setclkMHz in
drivers/video/imsttfb.c, the variable clk_p is never assigned a value
other than 0.
Could someone understanding this code decide whether this is a real bug
or whether clk_p can be replaced by 0?
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
@ 2006-01-06 16:25 Adrian Bunk
2006-01-07 1:34 ` [Linux-fbdev-devel] " Antonino A. Daplas
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-01-06 16:25 UTC (permalink / raw)
To: adaplas; +Cc: linux-fbdev-devel, linux-kernel
The Coverity checker noticed that in the function setclkMHz in
drivers/video/imsttfb.c, the variable clk_p is never assigned a value
other than 0.
Could someone understanding this code decide whether this is a real bug
or whether clk_p can be replaced by 0?
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-fbdev-devel] drivers/video/imsttfb.c: setclkMHz: clk_p is always 0
2006-01-06 16:25 drivers/video/imsttfb.c: setclkMHz: clk_p is always 0 Adrian Bunk
@ 2006-01-07 1:34 ` Antonino A. Daplas
0 siblings, 0 replies; 3+ messages in thread
From: Antonino A. Daplas @ 2006-01-07 1:34 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: adaplas, linux-kernel
Adrian Bunk wrote:
> The Coverity checker noticed that in the function setclkMHz in
> drivers/video/imsttfb.c, the variable clk_p is never assigned a value
> other than 0.
>
> Could someone understanding this code decide whether this is a real bug
> or whether clk_p can be replaced by 0?
>
It does look like to be an oversight. The same is present in Xorg code
too.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-07 1:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-06 16:25 drivers/video/imsttfb.c: setclkMHz: clk_p is always 0 Adrian Bunk
2006-01-07 1:34 ` [Linux-fbdev-devel] " Antonino A. Daplas
-- strict thread matches above, loose matches on Subject: below --
2005-03-22 19:53 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).