From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, David Vrabel <dvrabel@arcom.com>
Cc: linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@pol.net>,
linux-fbdev-devel@lists.sourceforge.net
Subject: [-mm patch] drivers/video/geode/video_gx.c: make struct gx_pll_table_48MHz static
Date: Fri, 10 Feb 2006 01:43:55 +0100 [thread overview]
Message-ID: <20060210004355.GJ3524@stusta.de> (raw)
In-Reply-To: <20060207220627.345107c3.akpm@osdl.org>
On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc1-mm5:
>...
> +fbdev-framebuffer-driver-for-geode-gx.patch
>...
> fbdev updates/drivers/fixes
>...
There is no good reason for struct gx_pll_table_48MHz being global.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc2-mm1-full/drivers/video/geode/video_gx.c.old 2006-02-10 00:55:07.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/video/geode/video_gx.c 2006-02-10 00:56:13.000000000 +0100
@@ -34,7 +34,7 @@
#define PREMULT2 ((u32)MSR_GLCP_SYS_RSTPLL_DOTPREMULT2)
#define PREDIV2 ((u32)MSR_GLCP_SYS_RSTPLL_DOTPOSTDIV3)
-struct gx_pll_entry gx_pll_table_48MHz[] = {
+static struct gx_pll_entry gx_pll_table_48MHz[] = {
{ 40123, POSTDIV3, 0x00000BF2 }, /* 24.9230 */
{ 39721, 0, 0x00000037 }, /* 25.1750 */
{ 35308, POSTDIV3|PREMULT2, 0x00000B1A }, /* 28.3220 */
next parent reply other threads:[~2006-02-10 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060207220627.345107c3.akpm@osdl.org>
2006-02-10 0:43 ` Adrian Bunk [this message]
2006-02-10 14:52 ` Radeonfb ignores video= parameter [was: Re: 2.6.16-rc2-mm1] Mattia Dongili
2006-02-10 15:14 ` [PATCH] fbdev: Fix typo in fbmem.c Antonino A. Daplas
2006-02-10 16:34 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060210004355.GJ3524@stusta.de \
--to=bunk@stusta.de \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=dvrabel@arcom.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).