Re: Re: [patch] [radeonfb] Radeon M26 and ATOM bios support (take 4)

[Stuffed Crust <pizza@shaftnet.org>]

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

On Wed, Mar 01, 2006 at 02:46:29PM +1100, Benjamin Herrenschmidt wrote:
> Or just write a small howto and I will do the job :) I've been very busy
> lately mostly due to my newborn child, thus I didn't help more than

Congratulations (and my condolances :P) on the kid!

> that, but I'm really interested in your work. I also want to bring along
> a bunch of fixes like the memory mapping fixes I've been doing on X.org
> radeon driver recently.

I often get lockups in a radeonfb console, could that be related 
to the mmap stuff you've been fixing?

> In fact, we need a way to provide the driver with the full connector
> mapping I think, in case it can't be obtained from the firmware.

I have a crude "bootstrap the connector table via ddc probing" but it 
has problems with secondary heads as well, and obviously without ddc it 
won't work anyway.  Either the user provices a connector table or we 
pray the defaults, one way or another, are sane.  :)

Of course, once a non-detectable layout is known, we can add it into an
appropriate driver table.

> module option is the easy/cheap way but sucks in some ways... sysfs per
> device instance is nice but a bit "too late" unless we have a way for
> the driver to re-probe... which is a good thing to have anyway since we
> might finally deal with screen hotplug :)

MM, that would be nice.. but I don't want to think about the console
interactions required for display reconfiguration.  That said, the new 
code is capable of re-detecting at any time, but I'm sure the radeonfb 
core has issues.

> I'll look at your stuff in more detail asap and will then let it simmer
> in -mm if I'm happy enough for at least a kernel version...

I'm about to mail out v5 of the patch.

 - Solomon
-- 
Solomon Peachy        				 ICQ: 1318344
Melbourne, FL
Quidquid latine dictum sit, altum viditur.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]