From: Alexander Kern <alex.kern@gmx.de>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH 16/18] atyfb: Remove dead code
Date: Sat, 11 Mar 2006 22:19:36 +0100 [thread overview]
Message-ID: <200603112219.37374.alex.kern@gmx.de> (raw)
In-Reply-To: <44122D2F.3080605@gmail.com>
Am Samstag, 11. März 2006 02:51 schrieb Antonino A. Daplas:
> Remove code that can never be reached.
>
> Coverity Bug 67
>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
Acked-by: Alexander Kern <alex.kern@gmx.de>
> ---
>
> drivers/video/aty/atyfb_base.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/aty/atyfb_base.c
> b/drivers/video/aty/atyfb_base.c index 1a5c0f6..c69c336 100644
> --- a/drivers/video/aty/atyfb_base.c
> +++ b/drivers/video/aty/atyfb_base.c
> @@ -2298,6 +2298,10 @@ static int __init aty_init(struct fb_inf
> case CLK_ATI18818_1:
> par->pll_ops = &aty_pll_ati18818_1;
> break;
> + case CLK_IBMRGB514:
> + par->pll_ops = &aty_pll_ibm514;
> + break;
> +#if 0 /* dead code */
> case CLK_STG1703:
> par->pll_ops = &aty_pll_stg1703;
> break;
> @@ -2307,9 +2311,7 @@ static int __init aty_init(struct fb_inf
> case CLK_ATT20C408:
> par->pll_ops = &aty_pll_att20c408;
> break;
> - case CLK_IBMRGB514:
> - par->pll_ops = &aty_pll_ibm514;
> - break;
> +#endif
> default:
> PRINTKI("aty_init: CLK type not implemented yet!");
> par->pll_ops = &aty_pll_unsupported;
--
Best Wishes
Mit freundlichen Grüßen
Alex Kern
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
prev parent reply other threads:[~2006-03-11 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-11 1:51 [PATCH 16/18] atyfb: Remove dead code Antonino A. Daplas
2006-03-11 21:19 ` Alexander Kern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603112219.37374.alex.kern@gmx.de \
--to=alex.kern@gmx.de \
--cc=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).