* [PATCH 16/18] atyfb: Remove dead code
@ 2006-03-11 1:51 Antonino A. Daplas
2006-03-11 21:19 ` Alexander Kern
0 siblings, 1 reply; 2+ messages in thread
From: Antonino A. Daplas @ 2006-03-11 1:51 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Fbdev development list, Alexander Kern,
Ville Syrjälä
Remove code that can never be reached.
Coverity Bug 67
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
drivers/video/aty/atyfb_base.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
index 1a5c0f6..c69c336 100644
--- a/drivers/video/aty/atyfb_base.c
+++ b/drivers/video/aty/atyfb_base.c
@@ -2298,6 +2298,10 @@ static int __init aty_init(struct fb_inf
case CLK_ATI18818_1:
par->pll_ops = &aty_pll_ati18818_1;
break;
+ case CLK_IBMRGB514:
+ par->pll_ops = &aty_pll_ibm514;
+ break;
+#if 0 /* dead code */
case CLK_STG1703:
par->pll_ops = &aty_pll_stg1703;
break;
@@ -2307,9 +2311,7 @@ static int __init aty_init(struct fb_inf
case CLK_ATT20C408:
par->pll_ops = &aty_pll_att20c408;
break;
- case CLK_IBMRGB514:
- par->pll_ops = &aty_pll_ibm514;
- break;
+#endif
default:
PRINTKI("aty_init: CLK type not implemented yet!");
par->pll_ops = &aty_pll_unsupported;
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 16/18] atyfb: Remove dead code
2006-03-11 1:51 [PATCH 16/18] atyfb: Remove dead code Antonino A. Daplas
@ 2006-03-11 21:19 ` Alexander Kern
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Kern @ 2006-03-11 21:19 UTC (permalink / raw)
To: Antonino A. Daplas; +Cc: Andrew Morton, Linux Fbdev development list
Am Samstag, 11. März 2006 02:51 schrieb Antonino A. Daplas:
> Remove code that can never be reached.
>
> Coverity Bug 67
>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
Acked-by: Alexander Kern <alex.kern@gmx.de>
> ---
>
> drivers/video/aty/atyfb_base.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/aty/atyfb_base.c
> b/drivers/video/aty/atyfb_base.c index 1a5c0f6..c69c336 100644
> --- a/drivers/video/aty/atyfb_base.c
> +++ b/drivers/video/aty/atyfb_base.c
> @@ -2298,6 +2298,10 @@ static int __init aty_init(struct fb_inf
> case CLK_ATI18818_1:
> par->pll_ops = &aty_pll_ati18818_1;
> break;
> + case CLK_IBMRGB514:
> + par->pll_ops = &aty_pll_ibm514;
> + break;
> +#if 0 /* dead code */
> case CLK_STG1703:
> par->pll_ops = &aty_pll_stg1703;
> break;
> @@ -2307,9 +2311,7 @@ static int __init aty_init(struct fb_inf
> case CLK_ATT20C408:
> par->pll_ops = &aty_pll_att20c408;
> break;
> - case CLK_IBMRGB514:
> - par->pll_ops = &aty_pll_ibm514;
> - break;
> +#endif
> default:
> PRINTKI("aty_init: CLK type not implemented yet!");
> par->pll_ops = &aty_pll_unsupported;
--
Best Wishes
Mit freundlichen Grüßen
Alex Kern
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-11 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-11 1:51 [PATCH 16/18] atyfb: Remove dead code Antonino A. Daplas
2006-03-11 21:19 ` Alexander Kern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).