From: Mardy <mardy@users.sourceforge.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Antonino A. Daplas" <adaplas@pol.net>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: Re: [PATCH] Add acceleration support to ATI Imageon
Date: Thu, 23 Mar 2006 14:28:25 +0100 [thread overview]
Message-ID: <20060323132825.GB10824@pupilla> (raw)
In-Reply-To: <44229A2E.1040109@pol.net>
Le die Thu, Mar 23, 2006 at 08:53:02PM +0800, Antonino A. Daplas ha scribite:
> >
> > I presume that w100_wait_complete is a "wait for engine idle" function?
Yes: without it, the characters were written in the framebuffer before
the copyarea operation actually took place. I didn't notice we had a
sync operation, too.
> > You can wrap w100_wait_complete() as w100fb_sync() and add this to fb_ops, ie
> >
> > .fb_sync = w100fb_sync.
Yes, it's definitely better.
> Although the result is the same, I prefer an OR (|) rather than
> addition (+)... At first glance, an OR makes you think of bitsetting
> while the addition is a bit confusing at first.
Will do, and resend a new patch.
Thanks!
--
Saluti,
Mardy
http://interlingua.altervista.org
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
next prev parent reply other threads:[~2006-03-23 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 11:29 [PATCH] Add acceleration support to ATI Imageon Mardy
2006-03-23 12:23 ` Geert Uytterhoeven
2006-03-23 13:22 ` Mardy
[not found] ` <4422987A.7030900@pol.net>
2006-03-23 12:53 ` Antonino A. Daplas
2006-03-23 13:28 ` Mardy [this message]
2006-03-23 17:18 ` [PATCH] Add acceleration support to ATI Imageon (new patch) Mardy
2006-03-23 17:35 ` [PATCH2] w100fb.h: convert bitfields to u32 Mardy
2006-03-25 0:39 ` [PATCH] Add acceleration support to ATI Imageon (new patch) Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323132825.GB10824@pupilla \
--to=mardy@users.sourceforge.net \
--cc=adaplas@pol.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).