* [RFC: 2.6 patch] video/sis/init301.c:SiS_ChrontelDoSomething2(): remove dead code
@ 2006-03-09 23:06 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-03-09 23:06 UTC (permalink / raw)
To: thomas; +Cc: adaplas, linux-fbdev-devel, linux-kernel
The Coverity checker spotted these two unused variables.
Please check whether this patch is correct or whether they should be
used.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/video/sis/init301.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
--- linux-2.6.16-rc5-mm3-full/drivers/video/sis/init301.c.old 2006-03-09 23:39:56.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/video/sis/init301.c 2006-03-09 23:40:48.000000000 +0100
@@ -8560,39 +8560,30 @@
}
}
static void
SiS_ChrontelDoSomething2(struct SiS_Private *SiS_Pr)
{
- unsigned short temp,tempcl,tempch;
+ unsigned short temp;
SiS_LongDelay(SiS_Pr, 1);
- tempcl = 3;
- tempch = 0;
do {
temp = SiS_GetCH701x(SiS_Pr,0x66);
temp &= 0x04; /* PLL stable? -> bail out */
if(temp == 0x04) break;
if(SiS_Pr->ChipType == SIS_740) {
/* Power down LVDS output, PLL normal operation */
SiS_SetCH701x(SiS_Pr,0x76,0xac);
}
SiS_SetCH701xForLCD(SiS_Pr);
- if(tempcl == 0) {
- if(tempch == 3) break;
- SiS_ChrontelResetDB(SiS_Pr);
- tempcl = 3;
- tempch++;
- }
- tempcl--;
temp = SiS_GetCH701x(SiS_Pr,0x76);
temp &= 0xfb; /* Reset PLL */
SiS_SetCH701x(SiS_Pr,0x76,temp);
SiS_LongDelay(SiS_Pr, 2);
temp = SiS_GetCH701x(SiS_Pr,0x76);
temp |= 0x04; /* PLL normal operation */
SiS_SetCH701x(SiS_Pr,0x76,temp);
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC: 2.6 patch] video/sis/init301.c:SiS_ChrontelDoSomething2(): remove dead code
@ 2006-03-25 19:47 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-03-25 19:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: thomas, adaplas, linux-fbdev-devel, linux-kernel
The Coverity checker spotted these two unused variables.
Please check whether this patch is correct or whether they should be
used.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 10 Mar 2006
drivers/video/sis/init301.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
--- linux-2.6.16-rc5-mm3-full/drivers/video/sis/init301.c.old 2006-03-09 23:39:56.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/video/sis/init301.c 2006-03-09 23:40:48.000000000 +0100
@@ -8560,39 +8560,30 @@
}
}
static void
SiS_ChrontelDoSomething2(struct SiS_Private *SiS_Pr)
{
- unsigned short temp,tempcl,tempch;
+ unsigned short temp;
SiS_LongDelay(SiS_Pr, 1);
- tempcl = 3;
- tempch = 0;
do {
temp = SiS_GetCH701x(SiS_Pr,0x66);
temp &= 0x04; /* PLL stable? -> bail out */
if(temp == 0x04) break;
if(SiS_Pr->ChipType == SIS_740) {
/* Power down LVDS output, PLL normal operation */
SiS_SetCH701x(SiS_Pr,0x76,0xac);
}
SiS_SetCH701xForLCD(SiS_Pr);
- if(tempcl == 0) {
- if(tempch == 3) break;
- SiS_ChrontelResetDB(SiS_Pr);
- tempcl = 3;
- tempch++;
- }
- tempcl--;
temp = SiS_GetCH701x(SiS_Pr,0x76);
temp &= 0xfb; /* Reset PLL */
SiS_SetCH701x(SiS_Pr,0x76,temp);
SiS_LongDelay(SiS_Pr, 2);
temp = SiS_GetCH701x(SiS_Pr,0x76);
temp |= 0x04; /* PLL normal operation */
SiS_SetCH701x(SiS_Pr,0x76,temp);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-25 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-25 19:47 [RFC: 2.6 patch] video/sis/init301.c:SiS_ChrontelDoSomething2(): remove dead code Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-03-09 23:06 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).