From: Jim Hague <jim.hague@acm.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>, adaplas@pol.net
Subject: Re: [PATCH] pm2fb section mismatches
Date: Mon, 17 Apr 2006 22:26:22 +0100 [thread overview]
Message-ID: <200604172226.23138.jim.hague@acm.org> (raw)
In-Reply-To: <20060414214905.375a308a.rdunlap@xenotime.net>
On Saturday 15 April 2006 05:49, Randy.Dunlap wrote:
> modpost warns:
>
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data:
> from .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7d4) WARNING:
> drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from
> .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7f9)
>
> These are due to pm2fb_set_par() referencing <lowhsync> and
> <lowvsync>, which are __devinitdata. Question is: can
> pm2fb_set_par() [or any fb_set_par method] be called after
> driver initializtion? I.e., do all of those calls in
> console/fbcon.c to fbops->fb_set_par() happen only during
> driver init, or can they happen later?
Just to confirm - I know calls to fb_set_par() happen after driver
init. 'lowhsync' and 'lowvsync' shouldn't be __devinitdata; it was ignorance
on my part that allowed another patch to make them so. Tony, please apply
Randy's patch.
--
Jim Hague - jim.hague@acm.org Never trust a computer you can't lift.
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
prev parent reply other threads:[~2006-04-17 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-15 4:49 [PATCH] pm2fb section mismatches Randy.Dunlap
2006-04-17 21:26 ` Jim Hague [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604172226.23138.jim.hague@acm.org \
--to=jim.hague@acm.org \
--cc=adaplas@pol.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).