[PATCH] pm2fb section mismatches

[PATCH] pm2fb section mismatches

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

modpost warns:

WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7d4)
WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7f9)

These are due to pm2fb_set_par() referencing <lowhsync> and
<lowvsync>, which are __devinitdata.  Question is:  can
pm2fb_set_par() [or any fb_set_par method] be called after
driver initializtion?  I.e., do all of those calls in
console/fbcon.c to fbops->fb_set_par() happen only during
driver init, or can they happen later?  If they can happen
later, then this patch is needed.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/video/pm2fb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2617-rc1g8.orig/drivers/video/pm2fb.c
+++ linux-2617-rc1g8/drivers/video/pm2fb.c
@@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
  * these flags allow the user to specify that requests for +ve sync
  * should be silently turned in -ve sync.
  */
-static int lowhsync __devinitdata = 0;
-static int lowvsync __devinitdata = 0;
+static int lowhsync;
+static int lowvsync;
 
 /*
  * The hardware state of the graphics card that isn't part of the


---


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

Re: [PATCH] pm2fb section mismatches

[Jim Hague]

On Saturday 15 April 2006 05:49, Randy.Dunlap wrote:
> modpost warns:
>
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference to .init.data:
> from .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7d4) WARNING:
> drivers/video/pm2fb.o - Section mismatch: reference to .init.data: from
> .text.pm2fb_set_par after 'pm2fb_set_par' (at offset 0x7f9)
>
> These are due to pm2fb_set_par() referencing <lowhsync> and
> <lowvsync>, which are __devinitdata.  Question is:  can
> pm2fb_set_par() [or any fb_set_par method] be called after
> driver initializtion?  I.e., do all of those calls in
> console/fbcon.c to fbops->fb_set_par() happen only during
> driver init, or can they happen later?

Just to confirm - I know calls to fb_set_par() happen after driver 
init. 'lowhsync' and 'lowvsync' shouldn't be __devinitdata; it was ignorance 
on my part that allowed another patch to make them so. Tony, please apply 
Randy's patch.
-- 
Jim Hague - jim.hague@acm.org          Never trust a computer you can't lift.


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642