linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: bunk@stusta.de, akpm@osdl.org, adaplas@pol.net,
	darrenrjenkins@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix section mismatch in pm2fb.o
Date: Tue, 18 Apr 2006 18:09:15 -0700	[thread overview]
Message-ID: <20060418180915.b67a7917.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060418235038.GC11582@stusta.de>

On Wed, 19 Apr 2006 01:50:38 +0200 Adrian Bunk wrote:

> From: Darren Jenkins <darrenrjenkins@gmail.com>
> 
> There are a couple of Section mismatch problems in drivers/video/pm2fb.o
> 
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference
> to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d)
> WARNING: drivers/video/pm2fb.o - Section mismatch: reference
> to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82)
> 
> They are caused because pm2fb_set_par() uses lowhsync and lowvsync which
> are marked __devinitdata.
> 
> This patch simply removes the __devinitdata annotations.
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
> This patch was already sent on:
> - 9 Apr 2006
> 
> --- 2.6.16-git20/drivers/video/pm2fb.c.orig	2006-04-03 19:08:51.000000000 +1000
> +++ 2.6.16-git20/drivers/video/pm2fb.c	2006-04-03 19:09:34.000000000 +1000
> @@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL;
>   * these flags allow the user to specify that requests for +ve sync
>   * should be silently turned in -ve sync.
>   */
> -static int lowhsync __devinitdata = 0;
> -static int lowvsync __devinitdata = 0;
> +static int lowhsync = 0;
> +static int lowvsync = 0;
>  
>  /*
>   * The hardware state of the graphics card that isn't part of the

I'll ack that since I've already posted it to linux-fbdev-devel
and it's been acked there.

---
~Randy


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

  reply	other threads:[~2006-04-19  1:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 23:50 [2.6 patch] fix section mismatch in pm2fb.o Adrian Bunk
2006-04-19  1:09 ` Randy.Dunlap [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-04-09 15:58 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060418180915.b67a7917.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=adaplas@pol.net \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=darrenrjenkins@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).