From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Subject: Re: [2.6 patch] fix section mismatch in pm2fb.o Date: Tue, 18 Apr 2006 18:09:15 -0700 Message-ID: <20060418180915.b67a7917.rdunlap@xenotime.net> References: <20060418235038.GC11582@stusta.de> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FW19g-0004zQ-5O for linux-fbdev-devel@lists.sourceforge.net; Tue, 18 Apr 2006 18:06:52 -0700 Received: from xenotime.net ([66.160.160.81]) by mail.sourceforge.net with smtp (Exim 4.44) id 1FW19e-0004FT-WF for linux-fbdev-devel@lists.sourceforge.net; Tue, 18 Apr 2006 18:06:52 -0700 Received: from midway.site ([71.111.157.99]) by xenotime.net for ; Tue, 18 Apr 2006 18:06:48 -0700 In-Reply-To: <20060418235038.GC11582@stusta.de> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: linux-fbdev-devel@lists.sourceforge.net Cc: bunk@stusta.de, akpm@osdl.org, adaplas@pol.net, darrenrjenkins@gmail.com, linux-kernel@vger.kernel.org On Wed, 19 Apr 2006 01:50:38 +0200 Adrian Bunk wrote: > From: Darren Jenkins > > There are a couple of Section mismatch problems in drivers/video/pm2fb.o > > WARNING: drivers/video/pm2fb.o - Section mismatch: reference > to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd5d) > WARNING: drivers/video/pm2fb.o - Section mismatch: reference > to .init.data: from .text after 'pm2fb_set_par' (at offset 0xd82) > > They are caused because pm2fb_set_par() uses lowhsync and lowvsync which > are marked __devinitdata. > > This patch simply removes the __devinitdata annotations. > > Signed-off-by: Darren Jenkins > Signed-off-by: Adrian Bunk > > --- > > This patch was already sent on: > - 9 Apr 2006 > > --- 2.6.16-git20/drivers/video/pm2fb.c.orig 2006-04-03 19:08:51.000000000 +1000 > +++ 2.6.16-git20/drivers/video/pm2fb.c 2006-04-03 19:09:34.000000000 +1000 > @@ -73,8 +73,8 @@ static char *mode __devinitdata = NULL; > * these flags allow the user to specify that requests for +ve sync > * should be silently turned in -ve sync. > */ > -static int lowhsync __devinitdata = 0; > -static int lowvsync __devinitdata = 0; > +static int lowhsync = 0; > +static int lowvsync = 0; > > /* > * The hardware state of the graphics card that isn't part of the I'll ack that since I've already posted it to linux-fbdev-devel and it's been acked there. --- ~Randy ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642