From: Andrew Morton <akpm@osdl.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, ralf@linux-mips.org
Subject: Re: [PATCH 3/5] au1100fb: Add power management support
Date: Sat, 27 May 2006 23:21:17 -0700 [thread overview]
Message-ID: <20060527232117.715e6a60.akpm@osdl.org> (raw)
In-Reply-To: <4478F1FD.2080702@gmail.com>
On Sun, 28 May 2006 08:42:37 +0800
"Antonino A. Daplas" <adaplas@gmail.com> wrote:
> From: Rodolfo Giometti <giometti@linux.it>
>
> Add power management support.
>
> int au1100fb_drv_suspend(struct device *dev, pm_message_t state)
> {
> - /* TODO */
> + struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
>
> int au1100fb_drv_resume(struct device *dev)
> {
> - /* TODO */
> + struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
These typecasts of void* are unneeded. They are in fact undesirable - if
someone were to change the type of dev_get_drvdata() to return some
non-pointer type then this code would still silently swallow it without
warning us of the bug.
Plus typecasts are ugly.
This patch doesn't apply, probably due to the earlier mangled one whihc I dropped.
Please redo and resend this one as well.
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
prev parent reply other threads:[~2006-05-28 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-28 0:42 [PATCH 3/5] au1100fb: Add power management support Antonino A. Daplas
2006-05-28 6:21 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060527232117.715e6a60.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).