From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 5/5] backlight: Fix Kconfig dependency Date: Sat, 27 May 2006 23:23:05 -0700 Message-ID: <20060527232305.954b7703.akpm@osdl.org> References: <4478F1DF.9080804@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from [10.3.1.93] (helo=sc8-sf-list1-new.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FkEc3-0004WK-CJ for linux-fbdev-devel@lists.sourceforge.net; Sat, 27 May 2006 23:18:55 -0700 Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1FkEc3-0006Ja-Ao for linux-fbdev-devel@lists.sourceforge.net; Sat, 27 May 2006 23:18:55 -0700 Received: from smtp.osdl.org ([65.172.181.4]) by mail.sourceforge.net with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.44) id 1FkEc3-0001tX-0Z for linux-fbdev-devel@lists.sourceforge.net; Sat, 27 May 2006 23:18:55 -0700 In-Reply-To: <4478F1DF.9080804@gmail.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: "Antonino A. Daplas" Cc: linux-fbdev-devel@lists.sourceforge.net, zap@homelink.ru, rpurdie@rpsys.net On Sun, 28 May 2006 08:42:07 +0800 "Antonino A. Daplas" wrote: > CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible > resulting in link errors. Fix by making backlight and lcd class also > depend on FB > > Signed-off-by: Antonino Daplas > --- > > drivers/video/backlight/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 02f1529..022f9d3 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT > > config BACKLIGHT_CLASS_DEVICE > tristate "Lowlevel Backlight controls" > - depends on BACKLIGHT_LCD_SUPPORT > + depends on BACKLIGHT_LCD_SUPPORT && FB > default m > help > This framework adds support for low-level control of the LCD > @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE > > config LCD_CLASS_DEVICE > tristate "Lowlevel LCD controls" > - depends on BACKLIGHT_LCD_SUPPORT > + depends on BACKLIGHT_LCD_SUPPORT && FB > default m > help > This framework adds support for low-level control of LCD. Would I be correct in believing that this is a mainline fix and hence 2.6.17 material? ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642