Re: [PATCH 2.6.17-rc6-mm2] fbdev: tag by scantype in sysfs

[Luca <kronos@people.it>]

Il Fri, Jun 23, 2006 at 09:04:41AM +0100, Daniel THOMPSON ha scritto: 
> > Secondly, that attribute 'modes' violate the 'one file, one value'
> > rule of
> > sysfs (and that includes 'virtual_size', and 'pan').  We need to clean
> > these up.  How about something like this?
> 
> Strictly speaking so does the mode string. This is, in fact, why adding
> information to it has the potential to break existing applications.
> 
> Ideally each mode should itself be a directory containing files like
> hsize, vsize, scantype, vfreq ...
> 
> Given each mode directory would have a unique name we could then use
> that to switch display modes (i.e. write an enumerated name rather than
> a mode string).
> 
> The problem with this approach is I can't think of any way to do the
> work currently performed by store_modes().

I think that configfs is able to deal with this using commitable items.
But having half of the framebuffer configured using sysfs and the other
half using configfs is a bit ugly :|

Luca
-- 
Home: http://kronoz.cjb.net
"Accadono cose che sono come domande. Passa un minuto, oppure anni, e
 poi la vita risponde."

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642