[RFC: 2.6 patch] drivers/video/aty/: possible cleanups

[RFC: 2.6 patch] drivers/video/aty/: possible cleanups

[Adrian Bunk]

This patch contains the following possible cleanups:
- make the following needlessly global function static:
  - mach64_ct.c: aty_st_pll_ct()
- proper prototypes for the following functions:
  - atyfb_base.c: atyfb_copyarea()
  - atyfb_base.c: atyfb_fillrect()
  - atyfb_base.c: atyfb_imageblit()

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/video/aty/atyfb.h      |    6 +++++-
 drivers/video/aty/atyfb_base.c |    3 ---
 drivers/video/aty/mach64_ct.c  |    2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)

--- linux-2.6.18-rc4-mm1/drivers/video/aty/atyfb.h.old	2006-08-13 23:45:13.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/video/aty/atyfb.h	2006-08-13 23:50:36.000000000 +0200
@@ -355,5 +355,9 @@
 
 extern void aty_reset_engine(const struct atyfb_par *par);
 extern void aty_init_engine(struct atyfb_par *par, struct fb_info *info);
-extern void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par);
 extern u8   aty_ld_pll_ct(int offset, const struct atyfb_par *par);
+
+void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);
+void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
+void atyfb_imageblit(struct fb_info *info, const struct fb_image *image);
+
--- linux-2.6.18-rc4-mm1/drivers/video/aty/mach64_ct.c.old	2006-08-13 23:45:31.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/video/aty/mach64_ct.c	2006-08-13 23:45:36.000000000 +0200
@@ -27,7 +27,7 @@
 	return res;
 }
 
-void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par)
+static void aty_st_pll_ct(int offset, u8 val, const struct atyfb_par *par)
 {
 	/* write addr byte */
 	aty_st_8(CLOCK_CNTL_ADDR, ((offset << 2) & PLL_ADDR) | PLL_WR_EN, par);
--- linux-2.6.18-rc4-mm1/drivers/video/aty/atyfb_base.c.old	2006-08-13 23:48:29.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/video/aty/atyfb_base.c	2006-08-13 23:50:25.000000000 +0200
@@ -240,9 +240,6 @@
 static int atyfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info);
 static int atyfb_blank(int blank, struct fb_info *info);
 static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg);
-extern void atyfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
-extern void atyfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);
-extern void atyfb_imageblit(struct fb_info *info, const struct fb_image *image);
 #ifdef __sparc__
 static int atyfb_mmap(struct fb_info *info, struct vm_area_struct *vma);
 #endif



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642