Fw: oops in aty128_bl_set_power in 2.6.18-rc5

Fw: oops in aty128_bl_set_power in 2.6.18-rc5

[Andrew Morton]

Begin forwarded message:

Date: Tue, 29 Aug 2006 18:26:06 +0200
From: Olaf Hering <olaf@aepfle.de>
To: linux-kernel@vger.kernel.org
Subject: oops in aty128_bl_set_power in 2.6.18-rc5



This oops happes on a G4/466 when X blanks the screen.

date:~ # lsmod
Module                  Size  Used by
snd_pcm_oss            61568  0 
snd_mixer_oss          21376  1 snd_pcm_oss
snd_seq                68160  0 
snd_seq_device         10028  1 snd_seq
r128                   44740  2 
drm                    79992  3 r128
ipv6                  291340  16 
loop                   19912  0 
dm_mod                 65424  0 
ehci_hcd               35752  0 
8139too                28032  0 
sungem                 34564  0 
sungem_phy             10368  1 sungem
uninorth_agp           10728  1 
mii                     6560  1 8139too
uhci_hcd               32460  0 
agpgart                36892  2 drm,uninorth_agp
ohci1394               39952  0 
snd_aoa_i2sbus         23876  0 
ieee1394              114352  1 ohci1394
snd_aoa_soundbus        7780  1 snd_aoa_i2sbus
ide_floppy             21728  0 
ide_cd                 47332  0 
cdrom                  43388  1 ide_cd
snd_powermac           50748  1 
snd_pcm                99332  3 snd_pcm_oss,snd_aoa_i2sbus,snd_powermac
snd_timer              28292  2 snd_seq,snd_pcm
snd                    73268  10 snd_pcm_oss,snd_mixer_oss,snd_seq,snd_seq_device,snd_aoa_i2sbus,snd_powermac,snd_pcm,snd_timer
soundcore              10980  1 snd
snd_page_alloc         11496  1 snd_pcm

...
Total memory = 256MB; using 512kB for hash table (at cff80000)
Linux version 2.6.18-rc5-default-mainline (olaf@pomegranate) (gcc version 4.1.0 (SUSE Linux)) #3 Tue Aug 29 16:41:44 CEST 2006
Found initrd at 0xc4100000:0xc4330000
Found UniNorth memory controller & host bridge @ 0xf8000000 revision: 0x11
Mapped at 0xfdfc0000
Found a Keylargo mac-io controller, rev: 3, mapped at 0xfdf40000
Processor NAP mode on idle enabled.
PowerMac motherboard: PowerMac G4 Silver
...
PCI: Enabling device 0000:00:10.0 (0086 -> 0087)
aty128fb: Invalid ROM signature 1111 should  be 0xaa55
aty128fb: BIOS not located, guessing timings.
aty128fb: Rage128 PF PRO AGP [chip rev 0x1] 16M 128-bit SDR SGRAM (1:1)
Console: switching to colour frame buffer device 128x48
fb0: ATY Rage128 frame buffer device on Rage128 PF PRO AGP
...
eth1: Link is up at 100 Mbps, full-duplex.
device-mapper: ioctl: 4.7.0-ioctl (2006-06-24) initialised: dm-devel@redhat.com
loop: loaded (max 8 devices)
kjournald starting.  Commit interval 5 seconds
EXT3-fs: mounted filesystem with ordered data mode.
eth0: link down
eth1: Link is up at 100 Mbps, full-duplex.
eth1: Pause is enabled (rxfifo: 10240 off: 7168 on: 5632)
NET: Registered protocol family 10
lo: Disabled Privacy Extensions
ADDRCONF(NETDEV_UP): eth0: link is not ready
IPv6 over IPv4 tunneling driver
[drm] Initialized drm 1.0.1 20051102
[drm] Initialized r128 2.5.0 20030725 on minor 0
agpgart: Putting AGP V2 device at 0000:00:0b.0 into 1x mode
agpgart: Putting AGP V2 device at 0000:00:10.0 into 1x mode
audit(1156867816.177:2): audit_pid=3980 old=0 by auid=4294967295
Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc01a62e8
Oops: Kernel access of bad area, sig: 11 [#1]

Modules linked in: snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device r128 drm ipv6 loop dm_mod ehci_hcd 8139too sungem sungem_phy uninorth_agp mii uhci_hcd agpgart ohci1394 snd_aoa_i2sbus ieee1394 snd_aoa_soundbus ide_floppy ide_cd cdrom snd_powermac snd_pcm snd_timer snd soundcore snd_page_alloc
NIP: C01A62E8 LR: C01A62E4 CTR: C01A6544
REGS: cdf95cc0 TRAP: 0300   Not tainted  (2.6.18-rc5-default-mainline)
MSR: 00009032 <EE,ME,IR,DR>  CR: 28002422  XER: 20000000
DAR: 00000000, DSISR: 40000000
TASK = ced218f0[3081] 'X' THREAD: cdf94000
GPR00: C01A62E4 CDF95D70 CED218F0 00000000 00000004 00004611 00000002 10220000
GPR08: 00004611 CDF94000 FFFFFFE7 00000000 00000000 10228A14 10220000 10220F0C
GPR16: 7FCDE570 10220F0C 10220000 10220000 7FCDE318 7FCDE570 10230000 00000000
GPR24: 10220000 101F0000 10220000 00000007 FFFFFFED C42F0000 C42F0214 00000004
NIP [C01A62E8] aty128_bl_set_power+0x28/0x9c
LR [C01A62E4] aty128_bl_set_power+0x24/0x9c
Call Trace:
[CDF95D70] [C01A62E4] aty128_bl_set_power+0x24/0x9c (unreliable)
[CDF95D90] [C01A65A8] aty128fb_blank+0x64/0x120
[CDF95DB0] [C01706DC] fb_blank+0x4c/0x84
[CDF95DE0] [C01716C0] fb_ioctl+0x4e4/0x5c4
[CDF95ED0] [C00977A0] do_ioctl+0x6c/0x84
[CDF95EE0] [C0097B38] vfs_ioctl+0x380/0x3b4
[CDF95F10] [C0097BD4] sys_ioctl+0x68/0x98
[CDF95F40] [C0012480] ret_from_syscall+0x0/0x40
--- Exception: c01 at 0xfd75f48
    LR = 0xfd75ee0
Instruction dump:
7c0803a6 4e800020 9421ffe0 7c0802a6 bfa10014 3bc30214 7c7d1b78 7fc3f378
90010024 7c9f2378 48125df1 807d0220 <7c001828> 30000001 7c00192d 40a2fff4

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Fw: oops in aty128_bl_set_power in 2.6.18-rc5

[Antonino A. Daplas]

On Tue, 2006-08-29 at 20:51 -0700, Andrew Morton wrote:

> NIP [C01A62E8] aty128_bl_set_power+0x28/0x9c
> LR [C01A62E4] aty128_bl_set_power+0x24/0x9c
> Call Trace:
> [CDF95D70] [C01A62E4] aty128_bl_set_power+0x24/0x9c (unreliable)
> [CDF95D90] [C01A65A8] aty128fb_blank+0x64/0x120
> [CDF95DB0] [C01706DC] fb_blank+0x4c/0x84
> [CDF95DE0] [C01716C0] fb_ioctl+0x4e4/0x5c4
> [CDF95ED0] [C00977A0] do_ioctl+0x6c/0x84
> [CDF95EE0] [C0097B38] vfs_ioctl+0x380/0x3b4
> [CDF95F10] [C0097BD4] sys_ioctl+0x68/0x98
> [CDF95F40] [C0012480] ret_from_syscall+0x0/0x40
> --- Exception: c01 at 0xfd75f48
>     LR = 0xfd75ee0

Backlight registration can fail resulting in info->bl_dev = NULL.  This
may be the cause of the oops.  An additional 'if (info->bl_dev)' check
in aty128_bl_set_power() may be necessary.

On another note, is the call to aty128_bl_set_power() from
aty128fb_blank() necessary? aty128_bl_set_power() will be called twice
per call to aty128fb_blank().

Tony



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Fw: oops in aty128_bl_set_power in 2.6.18-rc5

[Michael Hanselmann]

On Wed, Aug 30, 2006 at 10:59:50PM +0800, Antonino A. Daplas wrote:
> Backlight registration can fail resulting in info->bl_dev = NULL.  This
> may be the cause of the oops.  An additional 'if (info->bl_dev)' check
> in aty128_bl_set_power() may be necessary.

Fixed in aty128fb and three other places in the patch below. I don't own
the hardware and can't test it myself. Thus I'd like you, or someone
else, to test it.

> On another note, is the call to aty128_bl_set_power() from
> aty128fb_blank() necessary? aty128_bl_set_power() will be called twice
> per call to aty128fb_blank().

Not exactly. It once checks for (blank) and once for (!blank). If you
look at the code, removing th second call would only unblank it on some
chips.

---
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/macintosh/via-pmu-backlight.c linux-2.6.18-rc5/drivers/macintosh/via-pmu-backlight.c
--- linux-2.6.18-rc5.orig/drivers/macintosh/via-pmu-backlight.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/macintosh/via-pmu-backlight.c	2006-08-29 22:40:58.000000000 +0200
@@ -168,11 +168,11 @@ void __init pmu_backlight_init()
 		mutex_unlock(&info->bl_mutex);
 	}
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = level;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 	mutex_lock(&pmac_backlight_mutex);
 	if (!pmac_backlight)
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/video/aty/aty128fb.c linux-2.6.18-rc5/drivers/video/aty/aty128fb.c
--- linux-2.6.18-rc5.orig/drivers/video/aty/aty128fb.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/video/aty/aty128fb.c	2006-08-30 18:59:54.000000000 +0200
@@ -1801,10 +1801,14 @@ static struct backlight_properties aty12
 static void aty128_bl_set_power(struct fb_info *info, int power)
 {
 	mutex_lock(&info->bl_mutex);
-	up(&info->bl_dev->sem);
-	info->bl_dev->props->power = power;
-	__aty128_bl_update_status(info->bl_dev);
-	down(&info->bl_dev->sem);
+
+	if (info->bl_dev) {
+		down(&info->bl_dev->sem);
+		info->bl_dev->props->power = power;
+		__aty128_bl_update_status(info->bl_dev);
+		up(&info->bl_dev->sem);
+	}
+
 	mutex_unlock(&info->bl_mutex);
 }
 
@@ -1839,11 +1843,11 @@ static void aty128_bl_init(struct aty128
 		219 * FB_BACKLIGHT_MAX / MAX_LEVEL);
 	mutex_unlock(&info->bl_mutex);
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = aty128_bl_data.max_brightness;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 #ifdef CONFIG_PMAC_BACKLIGHT
 	mutex_lock(&pmac_backlight_mutex);
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/video/aty/atyfb_base.c linux-2.6.18-rc5/drivers/video/aty/atyfb_base.c
--- linux-2.6.18-rc5.orig/drivers/video/aty/atyfb_base.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/video/aty/atyfb_base.c	2006-08-30 19:23:29.000000000 +0200
@@ -2200,10 +2200,14 @@ static struct backlight_properties aty_b
 static void aty_bl_set_power(struct fb_info *info, int power)
 {
 	mutex_lock(&info->bl_mutex);
-	up(&info->bl_dev->sem);
-	info->bl_dev->props->power = power;
-	__aty_bl_update_status(info->bl_dev);
-	down(&info->bl_dev->sem);
+
+	if (info->bl_dev) {
+		down(&info->bl_dev->sem);
+		info->bl_dev->props->power = power;
+		__aty_bl_update_status(info->bl_dev);
+		up(&info->bl_dev->sem);
+	}
+
 	mutex_unlock(&info->bl_mutex);
 }
 
@@ -2234,11 +2238,11 @@ static void aty_bl_init(struct atyfb_par
 		0xFF * FB_BACKLIGHT_MAX / MAX_LEVEL);
 	mutex_unlock(&info->bl_mutex);
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = aty_bl_data.max_brightness;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 #ifdef CONFIG_PMAC_BACKLIGHT
 	mutex_lock(&pmac_backlight_mutex);
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/video/aty/radeon_backlight.c linux-2.6.18-rc5/drivers/video/aty/radeon_backlight.c
--- linux-2.6.18-rc5.orig/drivers/video/aty/radeon_backlight.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/video/aty/radeon_backlight.c	2006-08-29 22:39:23.000000000 +0200
@@ -195,11 +195,11 @@ void radeonfb_bl_init(struct radeonfb_in
 		217 * FB_BACKLIGHT_MAX / MAX_RADEON_LEVEL);
 	mutex_unlock(&rinfo->info->bl_mutex);
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = radeon_bl_data.max_brightness;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 #ifdef CONFIG_PMAC_BACKLIGHT
 	mutex_lock(&pmac_backlight_mutex);
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/video/nvidia/nv_backlight.c linux-2.6.18-rc5/drivers/video/nvidia/nv_backlight.c
--- linux-2.6.18-rc5.orig/drivers/video/nvidia/nv_backlight.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/video/nvidia/nv_backlight.c	2006-08-30 19:24:21.000000000 +0200
@@ -113,10 +113,14 @@ static struct backlight_properties nvidi
 void nvidia_bl_set_power(struct fb_info *info, int power)
 {
 	mutex_lock(&info->bl_mutex);
-	up(&info->bl_dev->sem);
-	info->bl_dev->props->power = power;
-	__nvidia_bl_update_status(info->bl_dev);
-	down(&info->bl_dev->sem);
+
+	if (info->bl_dev) {
+		down(&info->bl_dev->sem);
+		info->bl_dev->props->power = power;
+		__nvidia_bl_update_status(info->bl_dev);
+		up(&info->bl_dev->sem);
+	}
+
 	mutex_unlock(&info->bl_mutex);
 }
 
@@ -151,11 +155,11 @@ void nvidia_bl_init(struct nvidia_par *p
 		0x534 * FB_BACKLIGHT_MAX / MAX_LEVEL);
 	mutex_unlock(&info->bl_mutex);
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = nvidia_bl_data.max_brightness;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 #ifdef CONFIG_PMAC_BACKLIGHT
 	mutex_lock(&pmac_backlight_mutex);
diff -Nrup --exclude-from linux-exclude-from linux-2.6.18-rc5.orig/drivers/video/riva/fbdev.c linux-2.6.18-rc5/drivers/video/riva/fbdev.c
--- linux-2.6.18-rc5.orig/drivers/video/riva/fbdev.c	2006-08-30 19:25:28.000000000 +0200
+++ linux-2.6.18-rc5/drivers/video/riva/fbdev.c	2006-08-30 19:24:49.000000000 +0200
@@ -355,10 +355,14 @@ static struct backlight_properties riva_
 static void riva_bl_set_power(struct fb_info *info, int power)
 {
 	mutex_lock(&info->bl_mutex);
-	up(&info->bl_dev->sem);
-	info->bl_dev->props->power = power;
-	__riva_bl_update_status(info->bl_dev);
-	down(&info->bl_dev->sem);
+
+	if (info->bl_dev) {
+		down(&info->bl_dev->sem);
+		info->bl_dev->props->power = power;
+		__riva_bl_update_status(info->bl_dev);
+		up(&info->bl_dev->sem);
+	}
+
 	mutex_unlock(&info->bl_mutex);
 }
 
@@ -393,11 +397,11 @@ static void riva_bl_init(struct riva_par
 		0x534 * FB_BACKLIGHT_MAX / MAX_LEVEL);
 	mutex_unlock(&info->bl_mutex);
 
-	up(&bd->sem);
+	down(&bd->sem);
 	bd->props->brightness = riva_bl_data.max_brightness;
 	bd->props->power = FB_BLANK_UNBLANK;
 	bd->props->update_status(bd);
-	down(&bd->sem);
+	up(&bd->sem);
 
 #ifdef CONFIG_PMAC_BACKLIGHT
 	mutex_lock(&pmac_backlight_mutex);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642