* [patch 17/25] atyfb: Remove FIXME
@ 2006-11-02 5:50 akpm
2006-11-02 8:03 ` Ville Syrjälä
2006-11-13 16:03 ` James Simmons
0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2006-11-02 5:50 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: akpm, adaplas, syrjala
From: Ville Syrjala <syrjala@sci.fi>
atyfb has used the auxiliary register aperture for a long time. Remove a
related FIXME which was accidentally left in.
Signed-off-by: Ville Syrjala <syrjala@sci.fi>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/video/aty/atyfb_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff -puN drivers/video/aty/atyfb_base.c~atyfb-remove-fixme drivers/video/aty/atyfb_base.c
--- a/drivers/video/aty/atyfb_base.c~atyfb-remove-fixme
+++ a/drivers/video/aty/atyfb_base.c
@@ -2601,9 +2601,8 @@ static int __devinit aty_init(struct fb_
par->pll_ops->init_pll(info, &par->pll);
/*
- * Last page of 8 MB (4 MB on ISA) aperture is MMIO
- * FIXME: we should use the auxiliary aperture instead so we can access
- * the full 8 MB of video RAM on 8 MB boards
+ * Last page of 8 MB (4 MB on ISA) aperture is MMIO,
+ * unless the auxiliary register aperture is used.
*/
if (!par->aux_start &&
_
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 17/25] atyfb: Remove FIXME
2006-11-02 5:50 [patch 17/25] atyfb: Remove FIXME akpm
@ 2006-11-02 8:03 ` Ville Syrjälä
2006-11-13 16:03 ` James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2006-11-02 8:03 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: akpm, adaplas
On Wed, Nov 01, 2006 at 09:50:29PM -0800, akpm@osdl.org wrote:
> From: Ville Syrjala <syrjala@sci.fi>
>
> atyfb has used the auxiliary register aperture for a long time. Remove a
> related FIXME which was accidentally left in.
None of my atyfb patches are critical so they can wait for 2.6.20.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 17/25] atyfb: Remove FIXME
2006-11-02 5:50 [patch 17/25] atyfb: Remove FIXME akpm
2006-11-02 8:03 ` Ville Syrjälä
@ 2006-11-13 16:03 ` James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: James Simmons @ 2006-11-13 16:03 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: akpm, adaplas, syrjala
Acked-by: James Simmons <jsimmons@infradead.org>
On Wed, 1 Nov 2006, akpm@osdl.org wrote:
> From: Ville Syrjala <syrjala@sci.fi>
>
> atyfb has used the auxiliary register aperture for a long time. Remove a
> related FIXME which was accidentally left in.
>
> Signed-off-by: Ville Syrjala <syrjala@sci.fi>
> Cc: "Antonino A. Daplas" <adaplas@pol.net>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/video/aty/atyfb_base.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff -puN drivers/video/aty/atyfb_base.c~atyfb-remove-fixme drivers/video/aty/atyfb_base.c
> --- a/drivers/video/aty/atyfb_base.c~atyfb-remove-fixme
> +++ a/drivers/video/aty/atyfb_base.c
> @@ -2601,9 +2601,8 @@ static int __devinit aty_init(struct fb_
> par->pll_ops->init_pll(info, &par->pll);
>
> /*
> - * Last page of 8 MB (4 MB on ISA) aperture is MMIO
> - * FIXME: we should use the auxiliary aperture instead so we can access
> - * the full 8 MB of video RAM on 8 MB boards
> + * Last page of 8 MB (4 MB on ISA) aperture is MMIO,
> + * unless the auxiliary register aperture is used.
> */
>
> if (!par->aux_start &&
> _
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-13 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-02 5:50 [patch 17/25] atyfb: Remove FIXME akpm
2006-11-02 8:03 ` Ville Syrjälä
2006-11-13 16:03 ` James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).