From: Andrew Morton <akpm@osdl.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvidiafb: fix unreachable code in nv10GetConfig
Date: Wed, 8 Nov 2006 12:13:11 -0800 [thread overview]
Message-ID: <20061108121311.29dd0bda.akpm@osdl.org> (raw)
In-Reply-To: <20061108195511.GK17028@localdomain>
On Wed, 8 Nov 2006 13:55:11 -0600
Nathan Lynch <ntl@pobox.com> wrote:
> Fix binary/logical operator typo which leads to unreachable code.
> Noticed while looking at other issues; I don't have the relevant
> hardware to test this.
>
>
> Signed-off-by: Nathan Lynch <ntl@pobox.com>
>
> --- linux-2.6-powerpc.git.orig/drivers/video/nvidia/nv_setup.c
> +++ linux-2.6-powerpc.git/drivers/video/nvidia/nv_setup.c
> @@ -262,7 +262,7 @@ static void nv10GetConfig(struct nvidia_
> #endif
>
> dev = pci_find_slot(0, 1);
> - if ((par->Chipset && 0xffff) == 0x01a0) {
> + if ((par->Chipset & 0xffff) == 0x01a0) {
> int amt = 0;
>
> pci_read_config_dword(dev, 0x7c, &amt);
That looks like a pretty significant bug. It'll cause the kernel to
potentially map the wrong amount of memory for all cards except the
NV_ARCH_04 type. Has been there for over a year though. hmm..
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-11-08 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 19:55 [PATCH] nvidiafb: fix unreachable code in nv10GetConfig Nathan Lynch
2006-11-08 20:13 ` Andrew Morton [this message]
2006-11-08 22:04 ` Nathan Lynch
2006-11-12 22:20 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108121311.29dd0bda.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).