[PATCH] pnx4008:fix NULL dereference in rgbfb

[PATCH] pnx4008:fix NULL dereference in rgbfb

[Vitaly Wool]

Hello folks,

the patch inlined fixes possible NULL dereference in pnxrgbfb.

 drivers/video/pnx4008/pnxrgbfb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>

Index: linux-2.6.18/drivers/video/pnx4008/pnxrgbfb.c
===================================================================
--- linux-2.6.18.orig/drivers/video/pnx4008/pnxrgbfb.c
+++ linux-2.6.18/drivers/video/pnx4008/pnxrgbfb.c
@@ -154,7 +154,8 @@ static int __devinit rgbfb_probe(struct 
 			goto err1;
 	}
 
-	if (!fb_get_options("pnxrgbfb", &option) && !strcmp(option, "nocursor"))
+	if (!fb_get_options("pnxrgbfb", &option) && option &&
+			!strcmp(option, "nocursor"))
 		rgbfb_ops.fb_cursor = no_cursor;
 
 	info->node = -1;

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: [PATCH] pnx4008:fix NULL dereference in rgbfb

[James Simmons]

Yipes. I see people are really getting around the blinking cursor issue.
People want printks to the framebuffer but they hate the cursor. What 
would be better is a patch for a option for fbcon to disable the cursor.

> Hello folks,
> 
> the patch inlined fixes possible NULL dereference in pnxrgbfb.
> 
>  drivers/video/pnx4008/pnxrgbfb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>
> 
> Index: linux-2.6.18/drivers/video/pnx4008/pnxrgbfb.c
> ===================================================================
> --- linux-2.6.18.orig/drivers/video/pnx4008/pnxrgbfb.c
> +++ linux-2.6.18/drivers/video/pnx4008/pnxrgbfb.c
> @@ -154,7 +154,8 @@ static int __devinit rgbfb_probe(struct 
>  			goto err1;
>  	}
>  
> -	if (!fb_get_options("pnxrgbfb", &option) && !strcmp(option, "nocursor"))
> +	if (!fb_get_options("pnxrgbfb", &option) && option &&
> +			!strcmp(option, "nocursor"))
>  		rgbfb_ops.fb_cursor = no_cursor;
>  
>  	info->node = -1;
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642