linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Hoffmann <chrmhoffmann@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fbdev-devel@lists.sourceforge.net,
	Christian Hoffmann <Christian.Hoffmann@wallstreetsystems.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Solomon Peachy <pizza@shaftnet.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: Fwd: [Suspend-devel] resume not working on acer ferrari 4005 with radeonfb enabled
Date: Wed, 15 Nov 2006 01:54:35 +0100	[thread overview]
Message-ID: <200611150154.39499.chrmhoffmann@gmail.com> (raw)
In-Reply-To: <1163542033.5940.156.camel@localhost.localdomain>


[-- Attachment #1.1: Type: text/plain, Size: 1345 bytes --]

On Tuesday 14 November 2006 23:07, Benjamin Herrenschmidt wrote:
> > I tried that patch, but the last message I see over netconsole (using
> > tg3) is: Suspending console(s)
> > and then nothing. Nothing on resume at all :(
> >
> > Adding some printks in the radeonfb_pci_suspend and radeonfb_pci_resume
> > (radeon_pm.c) didn't help: I don't see them. But I am not a kernel
> > programmer at all, so I might do something wrong or in the wrong place.
>
> Does it resume if you make radeon_pci_resume() a nop ?
>
> Of course, the fbdev will not come back, but will the machine overall
> resume ?
>
> Ben.
Yes, if i make radeon_pci_resume a nop, the machine resumes if i do a return 0 
immediately.
I think I tracked it down to the call to acquire_console_sem() as the 
following code makes the machine hang again:

int radeonfb_pci_resume(struct pci_dev *pdev)
{
        struct fb_info *info = pci_get_drvdata(pdev);
        struct radeonfb_info *rinfo = info->par;
        int rc = 0;
        if (pdev->dev.power.power_state.event == PM_EVENT_ON)
                return 0;
        if (rinfo->no_schedule) {
        /*      if (try_acquire_console_sem())*/
                        return 0;
        } else
                acquire_console_sem();

        return 0;
...

Chris
NB: kernel 2.6.18.1, amd64




[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

  reply	other threads:[~2006-11-15  0:54 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-13 22:08 Fwd: [Suspend-devel] resume not working on acer ferrari 4005 with radeonfb enabled Christian Hoffmann
2006-11-13 23:08 ` Rafael J. Wysocki
2006-11-14 18:51   ` Christian Hoffmann
2006-11-14 21:47   ` Christian Hoffmann
2006-11-14 22:07     ` Benjamin Herrenschmidt
2006-11-15  0:54       ` Christian Hoffmann [this message]
2006-11-15  1:48         ` Benjamin Herrenschmidt
2006-11-15 10:09           ` Rafael J. Wysocki
2006-11-16 22:17             ` Christian Hoffmann
2006-11-16 22:44               ` Rafael J. Wysocki
2006-11-17  5:27                 ` [Linux-fbdev-devel] " Stuffed Crust
2006-11-17  6:17                   ` Benjamin Herrenschmidt
2006-11-17 14:36                     ` [Linux-fbdev-devel] " Stuffed Crust
2006-11-17 21:57                       ` Benjamin Herrenschmidt
2006-11-17  6:07               ` [Linux-fbdev-devel] " Stuffed Crust
2006-11-17 15:41                 ` Stuffed Crust
2006-11-17 20:33                   ` Christian Hoffmann
2006-11-17 21:59                     ` Benjamin Herrenschmidt
2006-11-17 22:02                       ` [Linux-fbdev-devel] Fwd: [Suspend-devel] resume not working onacer " Christian Hoffmann
2006-11-17 22:34                         ` Benjamin Herrenschmidt
2006-11-14 22:36     ` [Linux-fbdev-devel] Fwd: [Suspend-devel] resume not working on acer " Rafael J. Wysocki
2006-11-14 22:56     ` Pavel Machek
2006-11-14 22:57       ` [Linux-fbdev-devel] " Rafael J. Wysocki
2006-11-14 23:12         ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2006-11-13 10:51 Christian Hoffmann
2006-11-13 14:06 ` Rafael J. Wysocki
2006-11-13 17:07 ` Pavel Machek
2006-11-11 23:02 Christian Hoffmann
2006-11-11 14:27 Christian Hoffmann
2006-11-11 11:36 Christian Hoffmann
2006-11-11 22:49 ` Benjamin Herrenschmidt
2006-11-12 12:13   ` Pavel Machek
2006-11-12 12:28     ` Rafael J. Wysocki
2006-11-11 10:17 Christian Hoffmann
2006-11-10 23:31 Rafael J. Wysocki
2006-11-11  1:49 ` Benjamin Herrenschmidt
2006-11-11  2:02   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611150154.39499.chrmhoffmann@gmail.com \
    --to=chrmhoffmann@gmail.com \
    --cc=Christian.Hoffmann@wallstreetsystems.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pizza@shaftnet.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).