From: "Jordan Crouse" <jordan.crouse@amd.com>
To: linux-fbdev-devel@lists.sourceforge.net, info-linux@ldcmail.amd.com
Cc: akpm@osdl.org
Subject: [PATCH 5/6] [PATCH] gxfb: Fixup flatpanel detection
Date: Tue, 28 Nov 2006 16:15:17 -0700 [thread overview]
Message-ID: <20061128231517.25769.43800.stgit@cosmic.amd.com> (raw)
In-Reply-To: <20061128230639.25769.43.stgit@cosmic.amd.com>
From: Jordan Crouse <jordan.crouse@amd.com>
Use the right MSR and bits to detect if the GX is strapped for TFT or CRT
Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
---
drivers/video/geode/display_gx.h | 2 +-
drivers/video/geode/gxfb_core.c | 2 +-
drivers/video/geode/video_gx.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/geode/display_gx.h b/drivers/video/geode/display_gx.h
index ba0ccc8..0af33f3 100644
--- a/drivers/video/geode/display_gx.h
+++ b/drivers/video/geode/display_gx.h
@@ -18,7 +18,7 @@ extern struct geode_dc_ops gx_dc_ops;
/* MSR that tells us if a TFT or CRT is attached */
#define GLD_MSR_CONFIG 0xC0002001
-#define GLD_MSR_CONFIG_FMT_FP 0x01
+#define GLD_MSR_CONFIG_DM_FP 0x40
/* Display controller registers */
diff --git a/drivers/video/geode/gxfb_core.c b/drivers/video/geode/gxfb_core.c
index d404f56..83ab18a 100644
--- a/drivers/video/geode/gxfb_core.c
+++ b/drivers/video/geode/gxfb_core.c
@@ -328,7 +328,7 @@ static int __init gxfb_probe(struct pci_
rdmsrl(GLD_MSR_CONFIG, val);
- if (val & GLD_MSR_CONFIG_FMT_FP)
+ if ((val & GLD_MSR_CONFIG_DM_FP) == GLD_MSR_CONFIG_DM_FP)
par->enable_crt = 0;
else
par->enable_crt = 1;
diff --git a/drivers/video/geode/video_gx.h b/drivers/video/geode/video_gx.h
index 8f1e85b..119d0ab 100644
--- a/drivers/video/geode/video_gx.h
+++ b/drivers/video/geode/video_gx.h
@@ -14,7 +14,7 @@ #define __VIDEO_GX_H__
extern struct geode_vid_ops gx_vid_ops;
/* GX Flatpanel control MSR */
-#define GX_VP_MSR_PAD_SELECT 0x2011
+#define GX_VP_MSR_PAD_SELECT 0xC0002011
#define GX_VP_PAD_SELECT_MASK 0x3FFFFFFF
#define GX_VP_PAD_SELECT_TFT 0x1FFFFFFF
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-11-28 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 23:06 [PATCH 0/6] Geode GX framebuffer patches Jordan Crouse
2006-11-28 23:14 ` [PATCH 1/6] FB: Get the Geode GX frambuffer size from the BIOS Jordan Crouse
2006-11-29 14:21 ` James Simmons
2006-11-28 23:14 ` [PATCH 2/6] [PATCH] gxfb: Fixups for the AMD Geode GX framebuffer driver Jordan Crouse
2006-11-29 14:21 ` James Simmons
2006-11-28 23:15 ` [PATCH 3/6] [PATCH] gxfb: Support flat panel timings Jordan Crouse
2006-11-29 14:21 ` James Simmons
2006-11-28 23:15 ` [PATCH 4/6] [PATCH] gxfb: Support command line options Jordan Crouse
2006-11-29 14:21 ` James Simmons
2006-11-28 23:15 ` Jordan Crouse [this message]
2006-11-29 14:22 ` [PATCH 5/6] [PATCH] gxfb: Fixup flatpanel detection James Simmons
2006-11-28 23:15 ` [PATCH 6/6] [PATCH] gxfb: Turn on the flatpanel power and data Jordan Crouse
2006-11-29 14:22 ` James Simmons
2006-11-29 0:10 ` [PATCH 0/6] Geode GX framebuffer patches Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128231517.25769.43800.stgit@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=akpm@osdl.org \
--cc=info-linux@ldcmail.amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).