From: Andrew Morton <akpm@osdl.org>
To: James Simmons <jsimmons@infradead.org>
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Proper backlight selection for fbdev drivers
Date: Wed, 13 Dec 2006 00:00:29 -0800 [thread overview]
Message-ID: <20061213000029.edd9c91e.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0612071757230.949@pentafluge.infradead.org>
On Thu, 7 Dec 2006 17:59:01 +0000 (GMT)
James Simmons <jsimmons@infradead.org> wrote:
> Try this patch. This should fix any module/built-in dependencys.
drivers/video/aty/atyfb_base.c: In function 'atyfb_blank':
drivers/video/aty/atyfb_base.c:2817: warning: implicit declaration of function 'machine_is'
drivers/video/aty/atyfb_base.c:2817: error: 'powermac' undeclared (first use in this function)
drivers/video/aty/atyfb_base.c:2817: error: (Each undeclared identifier is reported only once
drivers/video/aty/atyfb_base.c:2817: error: for each function it appears in.)
This is i386 build.
#ifdef CONFIG_FB_ATY_BACKLIGHT
if (machine_is(powermac) && blank > FB_BLANK_NORMAL)
aty_bl_set_power(info, FB_BLANK_POWERDOWN);
#elif defined(CONFIG_FB_ATY_GENERIC_LCD)
It assumes that only pmacs have backlights.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-12-13 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 17:59 [PATCH] Proper backlight selection for fbdev drivers James Simmons
2006-12-13 8:00 ` Andrew Morton [this message]
2006-12-13 14:58 ` James Simmons
2006-12-13 19:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213000029.edd9c91e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).