linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <syrjala@sci.fi>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] updated proper-backlight-selection-for-fbdev-drivers.patch
Date: Thu, 14 Dec 2006 08:40:02 +0200	[thread overview]
Message-ID: <20061214064002.GB12910@sci.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0612131530340.4484@pentafluge.infradead.org>

On Wed, Dec 13, 2006 at 03:32:09PM +0000, James Simmons wrote:
> 
> Signed-Off-By: James Simmons <jsimmons@www.infradead.org>
> 
> Here is the updated patch for proper backlight selection.
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
...
> @@ -1135,8 +1140,7 @@ config FB_ATY_GX
>  
>  config FB_ATY_BACKLIGHT
>  	bool "Support for backlight control"
> -	depends on FB_ATY && PMAC_BACKLIGHT
> -	select FB_BACKLIGHT
> +	depends on FB_ATY
>  	default y
>  	help
>  	  Say Y here if you want to control the backlight of your display.

Is there some non-Mac hardware on which the backlight control actually 
works? IIRC I tried it on some x86 laptops at some point and it didn't 
do anything, and that is why I added the generic backlight voltage 
on/off thing. Just to be sure I can re-test my laptops next weekend...

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

      reply	other threads:[~2006-12-14  6:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-13 15:32 [PATCH] updated proper-backlight-selection-for-fbdev-drivers.patch James Simmons
2006-12-14  6:40 ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214064002.GB12910@sci.fi \
    --to=syrjala@sci.fi \
    --cc=akpm@osdl.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).