Re: [PATCH] savagefb: vsync for twisterP

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 20 Dec 2006 10:59:32 +0100 (CET) Mark Pustjens wrote:

> Ofcourse, I have to actually *add* the patch :)

Preferably not as an attachment, but as inline text.
Pine can usually do that without problems.


> On Wed, 20 Dec 2006, Mark Pustjens wrote:
> 
> > Hi,
> >
> > This patch add support to the savagefb driver for
> > waiting for vsync for the TwisterP chipset.
> >
> > The patch adds an ioctl FBIO_WAITFORVSYNC just like the
> > matroxfb driver.
> >
> > It probably needs some work.

Here are some comments.

1.  Use tabs consistently for indentation.  The patch has lots
of mixed spaces/tabs, e.g.:

+	struct savagefb_par *par = dev_id;
+        u_int32_t status;
+        int handled = 0;
+	unsigned char b;

2.  Function opening brace goes on a line by itself, not like this
(and other places):

+int savagefb_enable_irq(struct fb_info *info, int reenable) {

3.  Use new irq request names.  This:

+                if (request_irq(par->pcidev->irq, savagefb_irq,
+                                SA_SHIRQ, "savagefb", par)) {

should use IRQF_SHARED instead of SA_SHIRQ.
See comment in linux/interrupt.h:

/*
 * Migration helpers. Scheduled for removal in 1/2007
 * Do not use for new code !
 */

4.  Try to keep source lines < 80 columns so that they are
easily readable in a term window.

5.  Linux switch/case style puts 'case' at the same indent
level as 'switch' to save on indentation.

6.  Don't wrap one-line if-s in braces.  I.e., drop these and
similar braces (and use tabs to indent):

+        if (ret) {
+                return ret;
+        }

7.  Use /* ... */ comment style, not // style.

8.  s/treshold/threshold/ (typo/spello)

---
~Randy

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV