From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/9] ps3: AV Settings Driver Date: Mon, 29 Jan 2007 17:15:02 +0100 Message-ID: <20070129161502.GA32313@lst.de> References: <20070126031236.GG18537@lst.de> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1HBZAV-0003pI-4V for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Jan 2007 08:15:43 -0800 Received: from verein.lst.de ([213.95.11.210] helo=mail.lst.de) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HBZAR-0003xc-36 for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Jan 2007 08:15:42 -0800 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: Paul Mackerras , Linux Frame Buffer Device Development , James Simmons , Christoph Hellwig , Linux/PPC Development On Mon, Jan 29, 2007 at 03:10:16PM +0100, Geert Uytterhoeven wrote: > On Fri, 26 Jan 2007, Christoph Hellwig wrote: > > Btw, the Kconfig and/or top of file comment really needs a better > > explanation what this "driver" is for. I also wonder why it's > > What about `PS3 AV settings driver library' instead of `PS3 AV controller > support'? Makes a little more sense, yes. > We can make FB_PS3 (and SND_PS3 later) select PS3_PS3AV. Is that better? > I prefer not to make it unconditional, as people who want to run their PS3s > headless don't need it. Ok. Even better would be handling it on the makefile level, by doing obj-$(CONFIG_FB_PS3) += ps3_av.o obj-$(CONFIG_SND_PS3) += ps3_av.o > I guess you want us to do the same for the virtual uart, i.e. let PS3_PS3AV and > PS3_SYS_MANAGER select PS3_VUART? Yes, that probably makes sense aswell. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV