From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
James Simmons <jsimmons@infradead.org>
Subject: Re: [Cbe-oss-dev] [PATCH 6/6] Cell: Draw SPE helper penguin logos
Date: Wed, 31 Jan 2007 02:15:39 +0100 [thread overview]
Message-ID: <200701310215.39837.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0701301902410.2830@pademelon.sonytel.be>
On Tuesday 30 January 2007 19:02, Geert Uytterhoeven wrote:
> +#ifdef CONFIG_LOGO
> + if (ret > 0) {
> + extern const struct linux_logo logo_spe_clut224;
> + fb_append_extra_logo(&logo_spe_clut224, ret);
> + }
> +#endif
You should not have the #ifdef nor the extern declaration in here.
A better way to do it would be to have in include/linux/linux_logo.h
(or similar):
extern const struct linux_logo logo_spe_clut224;
#ifdef CONFIG_LOGO
extern void fb_append_extra_logo(const struct linux_logo *logo, int n);
#else
static inline void fb_append_extra_logo(const struct linux_logo *logo, int n)
{
}
#endif
Arnd <><
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2007-01-31 1:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 18:00 [PATCH 0/6] RFC Cell SPE logos Geert Uytterhoeven
2007-01-30 18:01 ` [PATCH 1/6] fbdev: Avoid vertical overflow when making space for the logo Geert Uytterhoeven
2007-01-30 18:01 ` [PATCH 2/6] fbdev: fb_do_show_logo() updates Geert Uytterhoeven
2007-01-30 18:02 ` [PATCH 3/6] fbdev: extract fb_show_logo_line() Geert Uytterhoeven
2007-01-30 18:02 ` [PATCH 4/6] fbdev: Add fb_append_extra_logo() Geert Uytterhoeven
2007-01-30 18:02 ` [PATCH 5/6] fbdev: SPE helper penguin logo Geert Uytterhoeven
2007-01-30 18:02 ` [PATCH 6/6] Cell: Draw SPE helper penguin logos Geert Uytterhoeven
2007-01-31 1:15 ` Arnd Bergmann [this message]
2007-01-31 1:19 ` [Cbe-oss-dev] [PATCH 0/6] RFC Cell SPE logos Arnd Bergmann
2007-01-31 1:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701310215.39837.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).