From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [Cbe-oss-dev] [PATCH 6/6] Cell: Draw SPE helper penguin logos Date: Wed, 31 Jan 2007 02:15:39 +0100 Message-ID: <200701310215.39837.arnd@arndb.de> References: Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1HC44q-0008D4-K3 for linux-fbdev-devel@lists.sourceforge.net; Tue, 30 Jan 2007 17:15:57 -0800 Received: from moutng.kundenserver.de ([212.227.126.187]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HC44o-00031T-Ll for linux-fbdev-devel@lists.sourceforge.net; Tue, 30 Jan 2007 17:15:56 -0800 In-Reply-To: Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: cbe-oss-dev@ozlabs.org Cc: Geert Uytterhoeven , Linux Frame Buffer Device Development , James Simmons On Tuesday 30 January 2007 19:02, Geert Uytterhoeven wrote: > +#ifdef CONFIG_LOGO > +=A0=A0=A0=A0=A0=A0=A0if (ret > 0) { > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0extern const struct linux_l= ogo logo_spe_clut224; > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0fb_append_extra_logo(&logo_= spe_clut224, ret); > +=A0=A0=A0=A0=A0=A0=A0} > +#endif You should not have the #ifdef nor the extern declaration in here. A better way to do it would be to have in include/linux/linux_logo.h (or similar): extern const struct linux_logo logo_spe_clut224; #ifdef CONFIG_LOGO extern void fb_append_extra_logo(const struct linux_logo *logo, int n); #else static inline void fb_append_extra_logo(const struct linux_logo *logo, int = n) { } #endif Arnd <>< ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE= VDEV