From: Ben Dooks <ben@fluff.org.uk>
To: openmoko-kernel@lists.openmoko.org,
linux-fbdev-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] s3c2410fb: fix un-initialised dev field
Date: Thu, 15 Feb 2007 22:49:23 +0000 [thread overview]
Message-ID: <20070215224922.GA7156@fluff.org.uk> (raw)
The current driver is not setting the dev
field in the private data structure, which
can lead to an OOPS if the driver tries to
report an error.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
--- linux-2.6.20/drivers/video/s3c2410fb.c 2007-02-04 18:44:54.000000000 +0000
+++ linux-2.6.20-fbfix1/drivers/video/s3c2410fb.c 2007-02-15 22:42:51.000000000 +0000
@@ -791,6 +791,8 @@ static int __init s3c2410fb_probe(struct
info = fbinfo->par;
info->fb = fbinfo;
+ info->dev = &pdev->dev;
+
platform_set_drvdata(pdev, fbinfo);
dprintk("devinit\n");
reply other threads:[~2007-02-15 22:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070215224922.GA7156@fluff.org.uk \
--to=ben@fluff.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openmoko-kernel@lists.openmoko.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).