From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [Linux-fbdev-devel] [PATCH] fb: sm501fb off-by-1 sysfs store Date: Thu, 1 Mar 2007 22:35:28 +0900 Message-ID: <20070301133528.GA6504@linux-sh.org> References: <20070301082456.GA3701@linux-sh.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: Cc: Ben Dooks , Linux Frame Buffer Device Development , Linux Kernel Development On Thu, Mar 01, 2007 at 02:25:55PM +0100, Geert Uytterhoeven wrote: > On Thu, 1 Mar 2007, Paul Mundt wrote: > > @@ -1074,9 +1074,9 @@ static ssize_t sm501fb_crtsrc_store(struct device *dev, > > if (len < 1) > > return -EINVAL; > > > > - if (strnicmp(buf, "crt", sizeof("crt")) == 0) > > + if (strnicmp(buf, "crt", 3) == 0) > > head = HEAD_CRT; > > - else if (strnicmp(buf, "panel", sizeof("panel")) == 0) > > + else if (strnicmp(buf, "panel", 5) == 0) > > head = HEAD_PANEL; > > else > > return -EINVAL; > > What about using just `strlen("string")' instead? ISTR gcc optimizes this to a > constant. Not that it matters that much, as the actual string won't be > duplicated. > I stuck with the constants since they were already referenced in the function, and there are enough other places in the kernel where they're used for these things. I didn't figure that 5 was a terribly high number to count to, but if there's expected difficulty, strlen() is of course an option. Personally I find it less visually offensive with constants, but as long as the end number is the same, I'm not too concerned with how we get there. Feel free to change it if you wish.