From: Greg KH <greg@kroah.com>
To: linux-fbdev-devel@lists.sourceforge.net, jsimmons@infradead.org,
stable@kernel.org, adaplas@gmail.com, alex.kern@gmx.de
Subject: Re: [stable] [PATCH] atyfb: Replace busy loop with mdelay()
Date: Tue, 6 Mar 2007 17:13:58 -0800 [thread overview]
Message-ID: <20070307011358.GB13624@kroah.com> (raw)
In-Reply-To: <20070306002943.GA9193@sci.fi>
On Tue, Mar 06, 2007 at 02:29:43AM +0200, Ville Syrj?l? wrote:
> On Mon, Mar 05, 2007 at 03:53:18PM -0800, Andrew Morton wrote:
> > @@ -614,7 +613,7 @@ static void aty_resume_pll_ct(const stru
> > * helps for Rage Mobilities that sometimes crash when
> > * we switch to sclk. (Daniel Mantione, 13-05-2003)
> > */
> > - for (i=0;i<=0x1ffff;i++);
> > + udelay(500);
>
> I'm not sure if 500 us is enough. The programmer's guide says you should
> allow 5 ms for the PLL to lock.
Then can you correct the patch in mainline, and forward what gets
accepted there to the stable team if you wish the change to also be made
there?
thanks,
greg k-h
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-03-07 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 0:20 [PATCH] atyfb: Replace busy loop with mdelay() Ville Syrjälä
2007-02-22 1:14 ` Antonino A. Daplas
2007-03-05 23:53 ` Andrew Morton
2007-03-06 0:29 ` Ville Syrjälä
2007-03-07 1:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307011358.GB13624@kroah.com \
--to=greg@kroah.com \
--cc=adaplas@gmail.com \
--cc=alex.kern@gmx.de \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).