linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* rivafb: fix initial brightness
@ 2007-03-18 22:58 Guido Guenther
  0 siblings, 0 replies; only message in thread
From: Guido Guenther @ 2007-03-18 22:58 UTC (permalink / raw)
  To: linux-fbdev-devel, Richard Purdie

Hi
this is the rivafb equivalent of
238576e12fef1d52751c6e08db2d0bdb0e248caf. It fixes rivafb having a
default backlight brightness of 0 (no picture at all) on a PBook 6,1.
Since this is a regression over 2.6.20, can this go into 2.6.21?
Cheers,
 -- Guido

Signed-Off-By: Guido Guenther <agx@sigxcpu.org>

diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c
index 1d1c7c6..d7ece8d 100644
--- a/drivers/video/riva/fbdev.c
+++ b/drivers/video/riva/fbdev.c
@@ -285,8 +285,6 @@ static const struct riva_regs reg_template = {
 #define MAX_LEVEL 0x534
 #define LEVEL_STEP ((MAX_LEVEL - MIN_LEVEL) / FB_BACKLIGHT_MAX)
 
-static struct backlight_properties riva_bl_data;
-
 static int riva_bl_get_level_brightness(struct riva_par *par,
 		int level)
 {
@@ -372,7 +370,7 @@ static void riva_bl_init(struct riva_par *par)
 		FB_BACKLIGHT_MAX);
 
 	bd->props.max_brightness = FB_BACKLIGHT_LEVELS - 1;
-	bd->props.brightness = riva_bl_data.max_brightness;
+	bd->props.brightness = bd->props.max_brightness;
 	bd->props.power = FB_BLANK_UNBLANK;
 	backlight_update_status(bd);
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-18 23:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-18 22:58 rivafb: fix initial brightness Guido Guenther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).