Re: [PATCH 5/7] rivafb: Fixed reversed DDC ports

Re: [PATCH 5/7] rivafb: Fixed reversed DDC ports

[Jean Delvare]

(Sorry for the referenceless reply, but I am not subscribed to
linux-fbdev-devel.)

> Fixed reversed DDC port so the assignments are congruent with nvidiafb's and
> X's nv driver.
> 
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
> ---
> 
>  drivers/video/riva/rivafb-i2c.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/riva/rivafb-i2c.c b/drivers/video/riva/rivafb-i2c.c
> index bcb2096..b9f1590 100644
> --- a/drivers/video/riva/rivafb-i2c.c
> +++ b/drivers/video/riva/rivafb-i2c.c
> @@ -133,11 +133,11 @@ void __devinit riva_create_i2c_busses(st
>  	par->chan[1].par	= par;
>  	par->chan[2].par        = par;
>  
> -	par->chan[0].ddc_base = 0x3e;
> -	par->chan[1].ddc_base = 0x36;
> +	par->chan[0].ddc_base = 0x36;
> +	par->chan[1].ddc_base = 0x3e;
>  	par->chan[2].ddc_base = 0x50;
> -	riva_setup_i2c_bus(&par->chan[0], "BUS1", 0);
> -	riva_setup_i2c_bus(&par->chan[1], "BUS2", I2C_CLASS_HWMON);
> +	riva_setup_i2c_bus(&par->chan[1], "BUS1", I2C_CLASS_HWMON);
> +	riva_setup_i2c_bus(&par->chan[0], "BUS2", 0);
>  	riva_setup_i2c_bus(&par->chan[2], "BUS3", 0);
>  }

Do you really want to swap &par->chan[0] and &par->chan[1] here? I
don't think so, otherwise it almost reverts the change you are doing -
and it breaks the classes, too.

-- 
Jean Delvare

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[PATCH 5/7] rivafb: Fixed reversed DDC ports

[Antonino A. Daplas]

Fixed reversed DDC port so the assignments are congruent with nvidiafb's and
X's nv driver.

Signed-off-by: Antonino Daplas <adaplas@pol.net>
---

 drivers/video/riva/rivafb-i2c.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/riva/rivafb-i2c.c b/drivers/video/riva/rivafb-i2c.c
index bcb2096..b9f1590 100644
--- a/drivers/video/riva/rivafb-i2c.c
+++ b/drivers/video/riva/rivafb-i2c.c
@@ -133,11 +133,11 @@ void __devinit riva_create_i2c_busses(st
 	par->chan[1].par	= par;
 	par->chan[2].par        = par;
 
-	par->chan[0].ddc_base = 0x3e;
-	par->chan[1].ddc_base = 0x36;
+	par->chan[0].ddc_base = 0x36;
+	par->chan[1].ddc_base = 0x3e;
 	par->chan[2].ddc_base = 0x50;
-	riva_setup_i2c_bus(&par->chan[0], "BUS1", 0);
-	riva_setup_i2c_bus(&par->chan[1], "BUS2", I2C_CLASS_HWMON);
+	riva_setup_i2c_bus(&par->chan[1], "BUS1", I2C_CLASS_HWMON);
+	riva_setup_i2c_bus(&par->chan[0], "BUS2", 0);
 	riva_setup_i2c_bus(&par->chan[2], "BUS3", 0);
 }
 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV