From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Dave Airlie <airlied@linux.ie>,
Jakob Bornecrantz <wallbraker@gmail.com>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: Console unregistration questions
Date: Tue, 24 Apr 2007 16:46:34 -0700 [thread overview]
Message-ID: <200704241646.34556.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1177458135.4829.5.camel@daplas>
On Tuesday, April 24, 2007, Antonino A. Daplas wrote:
> > > Also, shouldn't callers of
> > > unregister_con_driver be checking return values? That would have
> > > made this bug a lot easier to find at least. :)
>
> Replying to myself:
>
> At this point, if unregister_con_driver() fails, it is too late for
> fbcon, the best thing to do is issue a BUG().
I guess there's no way to propagate the error back to
unregister_framebuffer? If we did, then it could return -EBUSY or
something, keeping the module loaded instead of unsafely allowing it to be
removed...
> However, I'll add extra code to unregister_framebuffer() that will check
> if it's safe for the driver to unload. The drivers may then choose to
> check it or not.
Sounds good.
Jesse
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-04-24 23:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 21:59 Console unregistration questions Jesse Barnes
2007-04-24 23:19 ` Antonino A. Daplas
2007-04-24 23:42 ` Antonino A. Daplas
2007-04-24 23:46 ` Jesse Barnes [this message]
2007-04-25 0:07 ` Antonino A. Daplas
2007-04-25 1:17 ` Antonino A. Daplas
2007-04-26 17:00 ` Jesse Barnes
2007-04-27 1:30 ` Jesse Barnes
2007-04-27 6:10 ` Antonino A. Daplas
2007-04-27 15:14 ` Jesse Barnes
2007-04-27 16:10 ` Antonino A. Daplas
2007-04-24 23:42 ` Jesse Barnes
2007-04-25 0:04 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704241646.34556.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=adaplas@gmail.com \
--cc=airlied@linux.ie \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=wallbraker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).