From: David Miller <davem@davemloft.net>
To: hskinnemoen@atmel.com
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] fbdev: Add support for AVR32
Date: Mon, 07 May 2007 13:47:26 -0700 (PDT) [thread overview]
Message-ID: <20070507.134726.21927689.davem@davemloft.net> (raw)
In-Reply-To: <11785512332033-git-send-email-hskinnemoen@atmel.com>
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
Date: Mon, 7 May 2007 17:20:33 +0200
> Provide framebuffer page protection flags and definitions of
> fb_readl/fb_writel for AVR32.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
This isn't directed to you specifically, I'm just making a general
comment.
We're at the point where these two snippets of code in the fb layer
are a total mess of ifdefs.
It's time we made an include/asm-foo/fb.h header file and abstracted
out the necessary details there.
next prev parent reply other threads:[~2007-05-07 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 15:20 [PATCH] fbdev: Add support for AVR32 Haavard Skinnemoen
2007-05-07 20:47 ` David Miller [this message]
2007-05-07 22:55 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-05-07 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507.134726.21927689.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).