From: Christoph Hellwig <hch@infradead.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories
Date: Thu, 17 May 2007 10:49:30 +0100 [thread overview]
Message-ID: <20070517094930.GA27627@infradead.org> (raw)
In-Reply-To: <464B78BC.4080900@gmail.com>
On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote:
> -#if defined(__sparc__) && !defined(__sparc_v9__)
> - /* Should never get here, all fb drivers should have their own
> - mmap routines */
> - return -EINVAL;
> -#else
> - /* !sparc32... */
> + if (fb_mmap_required())
> + return -EINVAL;
> +
I don't like this bit. It's just that all sparc frame buffers happen
to have a mmap method but there's nothing fundamentally arch specific
here. You should be able to plug a pci video card into any linux
supported machine provided the fb driver does the full setup (which
only very few do in practice, but..)
So I'd just require drivers to have a fb_mmap method and make fb_mmap
the default one. The page protection cleanup is still nice of course,
but it might make sense to give it a more generic name as it's not
really fb specific.
next prev parent reply other threads:[~2007-05-17 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 21:33 [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories Antonino A. Daplas
2007-05-16 21:53 ` David Miller
2007-05-16 22:59 ` Antonino A. Daplas
2007-05-17 0:54 ` Kumar Gala
2007-05-17 6:13 ` Antonino A. Daplas
2007-05-17 9:43 ` Geert Uytterhoeven
2007-05-17 10:52 ` Antonino A. Daplas
2007-05-17 9:49 ` Christoph Hellwig [this message]
2007-05-17 10:51 ` Antonino A. Daplas
2007-05-17 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517094930.GA27627@infradead.org \
--to=hch@infradead.org \
--cc=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).