* [PATCH 2/4] fbdev: add connector entries for uvesafb
@ 2007-06-23 10:51 Michal Januszewski
2007-06-23 18:06 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Michal Januszewski @ 2007-06-23 10:51 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: linux-kernel
Add connector's idx and val constants for v86d and uvesafb.
Also change the maximum message size to 4k to allow transfers of VBE
data blocks from userspace.
Signed-off-by: Michal Januszewski <spock@gentoo.org>
---
include/linux/connector.h | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/connector.h b/include/linux/connector.h
index 10eb56b..46b2aba 100644
--- a/include/linux/connector.h
+++ b/include/linux/connector.h
@@ -36,14 +36,15 @@
#define CN_VAL_CIFS 0x1
#define CN_W1_IDX 0x3 /* w1 communication */
#define CN_W1_VAL 0x1
+#define CN_IDX_V86D 0x4
+#define CN_VAL_V86D_UVESAFB 0x1
-
-#define CN_NETLINK_USERS 4
+#define CN_NETLINK_USERS 5
/*
* Maximum connector's message size.
*/
-#define CONNECTOR_MAX_MSG_SIZE 1024
+#define CONNECTOR_MAX_MSG_SIZE 4096
/*
* idx and val are unique identifiers which
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] fbdev: add connector entries for uvesafb
2007-06-23 10:51 [PATCH 2/4] fbdev: add connector entries for uvesafb Michal Januszewski
@ 2007-06-23 18:06 ` Andrew Morton
2007-06-23 20:05 ` Evgeniy Polyakov
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-06-23 18:06 UTC (permalink / raw)
To: spock; +Cc: Evgeniy Polyakov, linux-fbdev-devel, linux-kernel
On Sat, 23 Jun 2007 12:51:46 +0200 Michal Januszewski <spock@gentoo.org> wrote:
> Add connector's idx and val constants for v86d and uvesafb.
>
> Also change the maximum message size to 4k to allow transfers of VBE
> data blocks from userspace.
>
> Signed-off-by: Michal Januszewski <spock@gentoo.org>
> ---
> include/linux/connector.h | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index 10eb56b..46b2aba 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -36,14 +36,15 @@
> #define CN_VAL_CIFS 0x1
> #define CN_W1_IDX 0x3 /* w1 communication */
> #define CN_W1_VAL 0x1
> +#define CN_IDX_V86D 0x4
> +#define CN_VAL_V86D_UVESAFB 0x1
>
> -
> -#define CN_NETLINK_USERS 4
> +#define CN_NETLINK_USERS 5
>
> /*
> * Maximum connector's message size.
> */
> -#define CONNECTOR_MAX_MSG_SIZE 1024
> +#define CONNECTOR_MAX_MSG_SIZE 4096
>
> /*
> * idx and val are unique identifiers which
>
>
Evgeniy, could you please review this?
The need to add these enumerations for unrelated subsystems to connector.h
may get a bit ugly as time passes, but I guess it's OK for now.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] fbdev: add connector entries for uvesafb
2007-06-23 18:06 ` Andrew Morton
@ 2007-06-23 20:05 ` Evgeniy Polyakov
0 siblings, 0 replies; 3+ messages in thread
From: Evgeniy Polyakov @ 2007-06-23 20:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: spock, linux-fbdev-devel, linux-kernel
On Sat, Jun 23, 2007 at 11:06:27AM -0700, Andrew Morton (akpm@linux-foundation.org) wrote:
> On Sat, 23 Jun 2007 12:51:46 +0200 Michal Januszewski <spock@gentoo.org> wrote:
>
> > Add connector's idx and val constants for v86d and uvesafb.
> >
> > Also change the maximum message size to 4k to allow transfers of VBE
> > data blocks from userspace.
> >
> > Signed-off-by: Michal Januszewski <spock@gentoo.org>
> > ---
> > include/linux/connector.h | 7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/connector.h b/include/linux/connector.h
> > index 10eb56b..46b2aba 100644
> > --- a/include/linux/connector.h
> > +++ b/include/linux/connector.h
> > @@ -36,14 +36,15 @@
> > #define CN_VAL_CIFS 0x1
> > #define CN_W1_IDX 0x3 /* w1 communication */
> > #define CN_W1_VAL 0x1
> > +#define CN_IDX_V86D 0x4
> > +#define CN_VAL_V86D_UVESAFB 0x1
> >
> > -
> > -#define CN_NETLINK_USERS 4
> > +#define CN_NETLINK_USERS 5
> >
> > /*
> > * Maximum connector's message size.
> > */
> > -#define CONNECTOR_MAX_MSG_SIZE 1024
> > +#define CONNECTOR_MAX_MSG_SIZE 4096
> >
> > /*
> > * idx and val are unique identifiers which
> >
> >
>
> Evgeniy, could you please review this?
>
> The need to add these enumerations for unrelated subsystems to connector.h
> may get a bit ugly as time passes, but I guess it's OK for now.
Hi.
I have no problem with the patch, although it could be possible to split
patch to two - add id and increase the size, but it is too minor nit.
Ack.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-23 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-23 10:51 [PATCH 2/4] fbdev: add connector entries for uvesafb Michal Januszewski
2007-06-23 18:06 ` Andrew Morton
2007-06-23 20:05 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).