Re: [PATCH 2/4] fbdev: add connector entries for uvesafb

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 23 Jun 2007 12:51:46 +0200 Michal Januszewski <spock@gentoo.org> wrote:

> Add connector's idx and val constants for v86d and uvesafb.
> 
> Also change the maximum message size to 4k to allow transfers of VBE
> data blocks from userspace.
> 
> Signed-off-by: Michal Januszewski <spock@gentoo.org>
> ---
> include/linux/connector.h |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index 10eb56b..46b2aba 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -36,14 +36,15 @@
>  #define CN_VAL_CIFS                     0x1
>  #define CN_W1_IDX			0x3	/* w1 communication */
>  #define CN_W1_VAL			0x1
> +#define CN_IDX_V86D			0x4
> +#define CN_VAL_V86D_UVESAFB		0x1
>  
> -
> -#define CN_NETLINK_USERS		4
> +#define CN_NETLINK_USERS		5
>  
>  /*
>   * Maximum connector's message size.
>   */
> -#define CONNECTOR_MAX_MSG_SIZE 	1024
> +#define CONNECTOR_MAX_MSG_SIZE 	4096
>  
>  /*
>   * idx and val are unique identifiers which 
> 
> 

Evgeniy, could you please review this?

The need to add these enumerations for unrelated subsystems to connector.h
may get a bit ugly as time passes, but I guess it's OK for now.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/