Re: [PATCH 3/4] fbdev: uvesafb driver

[Bernhard Fischer <rep.dot.nop@gmail.com>]

On Sat, Jun 23, 2007 at 12:52:43PM +0200, Michal Januszewski wrote:

>+static void uvesafb_cn_callback(void *data)
>+{
>+	struct cn_msg *msg = (struct cn_msg *)data;
>+	struct uvesafb_task *utask = (struct uvesafb_task *)msg->data;
>+	struct uvesafb_ktask *task;
>+
>+	if (msg->seq >= UVESAFB_TASKS_MAX)
>+		return;
>+
>+	task = uvfb_tasks[msg->seq];
>+
>+	if (!task || msg->ack != task->ack)
>+		return;

You need utask only here, so could spare setting it before the
checking above.
>+
>+	memcpy(&task->t, utask, sizeof(struct uvesafb_task));
>+
>+	if (task->t.buf_len && task->buf)
>+		memcpy(task->buf, ((u8*)utask) + sizeof(struct uvesafb_task),
>+						task->t.buf_len);
>+
>+	complete(task->done);
>+	return;
>+}

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/