From: Sam Ravnborg <sam@ravnborg.org>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
akpm@linux-foundation.org, Tony Lindgren <tony@atomide.com>,
imre.deak@solidboot.com, juha.yrjola@solidboot.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver
Date: Tue, 26 Jun 2007 18:50:03 +0200 [thread overview]
Message-ID: <20070626165003.GA22389@uranus.ravnborg.org> (raw)
In-Reply-To: <5d5443650706260533r218c05b1u5d4336015c4a4a9b@mail.gmail.com>
diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
new file mode 100644
index 0000000..5aa7175
--- /dev/null
+++ b/drivers/video/omap/Makefile
@@ -0,0 +1,10 @@
+#
+# Makefile for the new OMAP framebuffer device driver
+#
+
+obj-$(CONFIG_FB_OMAP) += omapfb.o
+
+objs-yy := omapfb_main.o
+
+omapfb-objs := $(objs-yy)
+
This looks strangs.
Please use:
obj-$(CONFIG_FB_OMAP) += omapfb.o
omapfb-y := omapfb_main.o
Or even better rename your .c file to omapfb.c then
you only need to use:
obj-$(CONFIG_FB_OMAP) += omapfb.o
Sam
next prev parent reply other threads:[~2007-06-26 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 12:33 [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver Trilok Soni
2007-06-26 16:50 ` Sam Ravnborg [this message]
2007-06-27 8:44 ` Trilok Soni
-- strict thread matches above, loose matches on Subject: below --
2007-06-19 11:46 Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626165003.GA22389@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=imre.deak@solidboot.com \
--cc=juha.yrjola@solidboot.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).