Re: [PATCH] pxafb: Add support for other palette formats

["Hans-Jürgen Koch" <hjk@linutronix.de>]

Am Dienstag 03 Juli 2007 18:03 schrieb Paulo Marques:
> Lothar Wassmann wrote:
> > Hi,
> > 
> >> Can userspace applications work with such a weired format?
> >> If yes, I'm looking forward to your patch.
> >>
> > At least framebuffer consoles don't work with that. So you should
> > add a configuration option that allows enabling the strange PXA pixel
> > formats only when CONFIG_FRAMEBUFFER_CONSOLE is not set.
> 
> Or maybe teach fbcon to use 18bpp modes?

This would only make sense if this is a common format that other
chips use, too.

> 
> > BTW: PXA255 doesn't have an LCCR4 register.
> 
> If we make sure that we don't touch LCCR4 registers unless the platform 
> driver asks for 18bpp we should be in the clear, no?
> 
> However, the current patch does write to LCCR4 without checking this, 
> but this should be a no-op if there is no register there, AFAICS.

Arrg, no, you can't do this. Even if it works on your current PXA255
revision, writing to a nonexistent register is certainly not something
we should do in a proper driver.

> 
> I'll try to handle it more correctly in my next patch, anyway.
>

So will I. I'll update my patch.

Thanks,
Hans


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/