From: "Hans-Jürgen Koch" <hjk@linutronix.de>
To: Lothar Wassmann <LW@karo-electronics.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-fbdev-devel@lists.sourceforge.net,
Paulo Marques <pmarques@grupopie.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] pxafb: Add support for other palette formats
Date: Tue, 3 Jul 2007 19:33:47 +0200 [thread overview]
Message-ID: <200707031933.47099.hjk@linutronix.de> (raw)
In-Reply-To: <18058.33810.378130.695740@ipc1.karo>
Am Dienstag 03 Juli 2007 19:14 schrieb Lothar Wassmann:
> Hi,
>
> > > BTW: PXA255 doesn't have an LCCR4 register.
> >
> > In that case I should insert some #ifdef CONFIG_PXA27x to have the
> > new behaviour only on PXA270, right?
> >
> This would be incompatible with the efforts to have the same kernel
> binary running on PXA25x as well as PXA27x.
OK, I see.
>
> Either check the cpuid
This is probably the right way to go if you actually want the binary
to run on both platforms.
> or as Paulo mentioned just check if the
> platform has defined a value for LCCR4 and assume that the platform
> code knows when to specify it and when not.
Well, my patch adds this definition to pxa_regs.h. Anyway, this solution
also decides at compile time where the binary will run.
Thanks,
Hans
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-03 17:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 14:07 [PATCH] pxafb: Add support for other palette formats Hans-Jürgen Koch
2007-07-03 14:46 ` Paulo Marques
2007-07-03 15:03 ` Hans-Jürgen Koch
2007-07-03 15:24 ` Paulo Marques
2007-07-03 15:50 ` Lothar Wassmann
2007-07-03 15:58 ` Geert Uytterhoeven
2007-07-12 7:56 ` Antonino A. Daplas
2007-07-12 8:01 ` Antonino A. Daplas
2007-07-03 16:03 ` Paulo Marques
2007-07-03 16:45 ` Hans-Jürgen Koch
2007-07-03 17:21 ` Paulo Marques
2007-07-03 17:44 ` Hans-Jürgen Koch
2007-07-03 18:18 ` Paulo Marques
2007-07-04 7:17 ` Lothar Wassmann
2007-07-04 11:00 ` Paulo Marques
2007-07-04 6:56 ` Lothar Wassmann
2007-07-03 16:39 ` Hans-Jürgen Koch
2007-07-03 17:14 ` Lothar Wassmann
2007-07-03 17:33 ` Hans-Jürgen Koch [this message]
2007-07-13 12:20 ` Antonino A. Daplas
2007-07-13 12:39 ` Hans-Jürgen Koch
2007-07-03 19:01 ` Clemens Koller
2007-07-03 19:11 ` Hans-Jürgen Koch
2007-07-03 20:36 ` Hans-Jürgen Koch
2007-07-04 6:38 ` eric miao
2007-07-04 7:51 ` Lothar Wassmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707031933.47099.hjk@linutronix.de \
--to=hjk@linutronix.de \
--cc=LW@karo-electronics.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=pmarques@grupopie.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).