From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org
Cc: James Simmons <jsimmons@infradead.org>,
"Antonino A. Daplas" <adaplas@gmail.com>,
linux-kernel@vger.kernel.org, Al Viro <viro@ftp.linux.org.uk>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linux-fbdev-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>
Subject: fbdev: make fb_append_extra_logo() depend on fb=y
Date: Wed, 18 Jul 2007 00:52:03 +0200 [thread overview]
Message-ID: <200707180052.04659.arnd@arndb.de> (raw)
In-Reply-To: <20070716135950.895120000@pademelon.sonytel.be>
We can't show the extra logo from boot code if FB is built as
a module. Make the FB_LOGO_EXTRA depend on FB=y.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Reported by Al Viro. I don't know how this ended up in the final
patch, as I'm pretty sure we talked about this scenario before
and had a solution...
diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig
index da219c0..9de1c11 100644
--- a/drivers/video/logo/Kconfig
+++ b/drivers/video/logo/Kconfig
@@ -12,7 +12,7 @@ if LOGO
config FB_LOGO_EXTRA
bool
- depends on FB
+ depends on FB=y
default y if SPU_BASE
config LOGO_LINUX_MONO
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-17 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 13:55 [patch 0/4] Cell SPE logos Geert Uytterhoeven
2007-07-16 13:55 ` [patch 1/4] fbdev: extract fb_show_logo_line() Geert Uytterhoeven
2007-07-16 13:55 ` [patch 2/4] fbdev: Add fb_append_extra_logo() Geert Uytterhoeven
2007-07-17 22:52 ` Arnd Bergmann [this message]
2007-07-18 6:15 ` fbdev: make fb_append_extra_logo() depend on fb=y Geert Uytterhoeven
2007-07-16 13:55 ` [patch 3/4] fbdev: SPE helper penguin logo Geert Uytterhoeven
2007-07-16 13:55 ` [patch 4/4] Cell: Draw SPE helper penguin logos Geert Uytterhoeven
2007-07-25 19:29 ` [patch 0/4] Cell SPE logos Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707180052.04659.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).