From: David Miller <davem@davemloft.net>
To: krzysztof.h1@wp.pl
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] cg6: accelerated copyarea
Date: Wed, 01 Aug 2007 21:44:03 -0700 (PDT) [thread overview]
Message-ID: <20070801.214403.21926765.davem@davemloft.net> (raw)
In-Reply-To: <20070802011735.a89bf72c.krzysztof.h1@wp.pl>
From: Krzysztof Helt <krzysztof.h1@wp.pl>
Date: Thu, 2 Aug 2007 01:17:35 +0200
> This patch requires both cg6-cleanup and cg6-fbmem-size-fix patches
> to apply cleanly.
It doesn't apply cleanly.
> +/**
> * cg6_imageblit - Copies a image from system memory to the screen.
> *
> * @info: frame buffer structure that represents a single frame buffer
That's not what the comment baove cg6_imageblit() looks like
with all the patches applied, instead it looks like:
/**
* cg6_imageblit - REQUIRED function. Can use generic routines if
* non acclerated hardware and packed pixel based.
* Copies a image from system memory to the screen.
*
* @info: frame buffer structure that represents a single frame buffer
* @image: structure defining the image.
*/
Perhaps we are speaking of two different cg6-cleanup patches.
In any event, I'll add this patch in by hand.
Please just submit SBUS framebuffer driver fixes directly to me since
I'm constantly fixing errors in these drivers on my own as well and
it's easier for me to resolve the conflicts.
Thanks.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-08-02 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 23:17 [PATCH] cg6: accelerated copyarea Krzysztof Helt
2007-08-02 4:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801.214403.21926765.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).