From: Andrew Morton <akpm@linux-foundation.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Linux Fbdev development list <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH 01/11] fbcon: Kill compile warning
Date: Wed, 1 Aug 2007 15:41:43 -0700 [thread overview]
Message-ID: <20070801154143.613d83da.akpm@linux-foundation.org> (raw)
In-Reply-To: <46B03735.9020803@gmail.com>
On Wed, 01 Aug 2007 15:33:09 +0800
"Antonino A. Daplas" <adaplas@gmail.com> wrote:
> +static inline void fbcon_map_override(void)
> +{
> + map_override = 1;
> +}
> +#else
> +#define fbcon_map_override(...) do { } while (0)
> +#endif /* CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY */
It's odd to use a C function in one case and a macro in the other.
Was there a reason to not use plain old static inline?
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-08-01 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 7:33 [PATCH 01/11] fbcon: Kill compile warning Antonino A. Daplas
2007-08-01 22:41 ` Andrew Morton [this message]
2007-08-02 1:23 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801154143.613d83da.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).