From: Michal Januszewski <spock@gentoo.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uvesafb: select connector in Kconfig
Date: Sun, 26 Aug 2007 11:35:44 +0200 [thread overview]
Message-ID: <20070826093544.GA4865@spock.one.pl> (raw)
In-Reply-To: <20070825082341.e939e38e.randy.dunlap@oracle.com>
On Sat, Aug 25, 2007 at 08:23:41AM -0700, Randy Dunlap wrote:
> There are 2 problems with this.
>
> a. CONNECTOR depends on NET, but select won't enable NET, so if
> NET is not enabled otherwise, CONNECTOR still won't build.
> This is a longstanding select/kconfig issue.
>
> b. CONNECTOR depends on NET, so if select did follow the depends
> chain and enable NET, it would be enabling the networking subsystem,
> which is something that should not be done quietly.
>
> select should only be used for enabling small library-like code
> (if even then). Avoid it whenever possible.
OK, thanks for pointing this out. Let's keep the original dependency
on CONNECTOR then.
Best regards,
Michal
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-08-26 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-25 8:59 [PATCH] uvesafb: select connector in Kconfig Michal Januszewski
2007-08-25 15:23 ` Randy Dunlap
2007-08-26 9:35 ` Michal Januszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070826093544.GA4865@spock.one.pl \
--to=spock@gentoo.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).