From: aherrman@arcor.de
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M
Date: Tue, 11 Sep 2007 00:38:18 +0200 [thread overview]
Message-ID: <20070910223818.GC5155@devil> (raw)
In-Reply-To: <1188913512.5972.147.camel@localhost.localdomain>
On Tue, Sep 04, 2007 at 03:45:12PM +0200, Benjamin Herrenschmidt wrote:
> On Tue, 2007-09-04 at 12:58 +0200, aherrman@arcor.de wrote:
> > .. which can be found in Acer Aspire 5100.
> >
> > Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Sorry, I have missed that 0x5975 was already defined for radeonfb.
So this patch shouldn't be applied.
We have already:
/*Mobility Xpress 200 */
CHIP_DEF(PCI_CHIP_RS485_5975, R300, CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
This was introduced with commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c
But obviously this is not correct as the 0x5975 is an RS48x not R300.
With the current git (w/o my patch) my display goes blank (or better it looks striped)
and the Laptop hangs.
I'll do some further tests on my Laptop and probably come up with a new patch.
Regards,
Andreas
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-09-10 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 10:58 [PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M aherrman
2007-09-04 13:45 ` Benjamin Herrenschmidt
2007-09-10 22:38 ` aherrman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910223818.GC5155@devil \
--to=aherrman@arcor.de \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).