From: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert.Uytterhoeven@sonycom.com, linuxppc-dev@ozlabs.org,
linux-fbdev-devel@lists.sourceforge.net, cbe-oss-dev@ozlabs.org,
adaplas@gmail.com
Subject: Re: [patch 12/13] fb: Move and rename extern declaration for global_mode_option
Date: Mon, 15 Oct 2007 14:43:40 -0700 [thread overview]
Message-ID: <20071015144340.167d1cda.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071012145130.867069000@pademelon.sonytel.be>
On Fri, 12 Oct 2007 16:51:04 +0200
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> - if (mode_option || (mode_option = global_mode_option)) {
> + if (mode_option || (mode_option = fb_mode_option)) {
I guess that equals-which-looks-like-it-should-be-equals-equals really
is intended to be an assignment?
I guess. After staring at it for a while. It's a pretty obnoxious way
of coding it, especially in kernel context where such things are unexpected...
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-15 21:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 14:50 [patch 00/13] ps3av/fb patches for 2.6.24 Geert Uytterhoeven
2007-10-12 14:50 ` [patch 01/13] ps3av: Fix black and white stripes Geert Uytterhoeven
2007-10-12 14:50 ` [patch 02/13] ps3fb: Fix spurious mode change failures Geert Uytterhoeven
2007-10-12 14:50 ` [patch 03/13] ps3fb: Convert from printk()/DPRINTK() to dev_*()/pr_*() Geert Uytterhoeven
2007-10-12 14:50 ` [patch 04/13] ps3fb: Do not print warnings on invalid frame numbers Geert Uytterhoeven
2007-10-12 14:50 ` [patch 05/13] ps3fb: Clean up includes Geert Uytterhoeven
2007-10-12 14:50 ` [patch 06/13] ps3fb: Make ps3fb_wait_for_vsync() and ps3fb_flip_ctl() static Geert Uytterhoeven
2007-10-12 14:50 ` [patch 07/13] ps3fb: Fix possible overlap of GPU command buffer and frame buffer Geert Uytterhoeven
2007-10-12 14:51 ` [patch 08/13] ps3fb: Use fb_info.par properly Geert Uytterhoeven
2007-10-12 14:51 ` [patch 09/13] ps3fb: Dont keep the borders for non-fullscreen modes in XDR memory Geert Uytterhoeven
2007-10-12 14:51 ` [patch 10/13] ps3fb: Add virtual screen and panning support Geert Uytterhoeven
2007-10-12 14:51 ` [patch 11/13] ps3fb: Enhance horizontal panning on firmware 1.90 and up Geert Uytterhoeven
2007-10-12 14:51 ` [patch 12/13] fb: Move and rename extern declaration for global_mode_option Geert Uytterhoeven
2007-10-15 21:43 ` Andrew Morton [this message]
2007-10-16 7:18 ` Geert Uytterhoeven
2007-10-12 14:51 ` [patch 13/13] ps3fb: Default to 480p on DVI-D/HDMI if video=safe Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015144340.167d1cda.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=adaplas@gmail.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).