From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Fannin Subject: vga16fb doesn't build on powerpc (vgacon_remap_base) Date: Tue, 16 Oct 2007 15:14:03 -0400 Message-ID: <20071016191403.GA5962@nineveh.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: linuxppc-dev@ozlabs.org Cc: linux-fbdev-devel@lists.sourceforge.net vga16fb is an available config option on powerpc, but it won't link with my .config: ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined! I'm guessing this is because include/asm-powerpc/vga.h declares vgacon_remap_base: extern unsigned long vgacon_remap_base; ...but arch/powerpc/kernel/setup_32.c wraps the definition in an #ifdef: #ifdef CONFIG_VGA_CONSOLE unsigned long vgacon_remap_base; EXPORT_SYMBOL(vgacon_remap_base); #endif So CONFIG_VGA_CONSOLE=n and CONFIG_FB_VGA16=[y|m] won't work. I've also noticed that the only places in the tree that ever assign anything to config_remap_base are under arch/ppc. And include/asm-powerpc/vga.h also does this: #ifdef __powerpc64__ #define VGA_MAP_MEM(x,s) ((unsigned long) ioremap((x), s)) #else #define VGA_MAP_MEM(x,s) (x + vgacon_remap_base) #endif So VGACON probably doesn't work either on 32bit. I'm guessing arch/powerpc doesn't support PREP. How best could this be fixed up? Or should I just let the thing be? This is obviously not a new thing, and I don't have any hardware that supports this stuff either. -- Joseph Fannin jfannin@gmail.com