* [PATCH] Silence radeon_pm warning
@ 2007-10-29 2:59 Stephen Rothwell
2007-10-29 3:06 ` David Miller
2007-10-29 5:02 ` Olof Johansson
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2007-10-29 2:59 UTC (permalink / raw)
To: Ben Herrenschmidt; +Cc: LKML, linux-fbdev-devel
drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared 'static' but never defined
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/video/aty/radeon_pm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --git a/drivers/video/aty/radeon_pm.c b/drivers/video/aty/radeon_pm.c
index be1d57b..f989836 100644
--- a/drivers/video/aty/radeon_pm.c
+++ b/drivers/video/aty/radeon_pm.c
@@ -27,7 +27,9 @@
#include "ati_ids.h"
+#ifdef CONFIG_PM
static void radeon_reinitialize_M10(struct radeonfb_info *rinfo);
+#endif
/*
* Workarounds for bugs in PC laptops:
--
1.5.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Silence radeon_pm warning
2007-10-29 2:59 [PATCH] Silence radeon_pm warning Stephen Rothwell
@ 2007-10-29 3:06 ` David Miller
2007-10-29 5:02 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-10-29 3:06 UTC (permalink / raw)
To: sfr; +Cc: benh, linux-fbdev-devel, linux-kernel
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Oct 2007 13:59:11 +1100
> drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared 'static' but never defined
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: David S. Miller <davem@davemloft.net>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Silence radeon_pm warning
2007-10-29 2:59 [PATCH] Silence radeon_pm warning Stephen Rothwell
2007-10-29 3:06 ` David Miller
@ 2007-10-29 5:02 ` Olof Johansson
2007-10-29 5:33 ` Stephen Rothwell
1 sibling, 1 reply; 4+ messages in thread
From: Olof Johansson @ 2007-10-29 5:02 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Ben Herrenschmidt, linux-fbdev-devel, LKML
On Mon, Oct 29, 2007 at 01:59:11PM +1100, Stephen Rothwell wrote:
> drivers/video/aty/radeon_pm.c:30: warning: 'radeon_reinitialize_M10' declared 'static' but never defined
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
I posted this one a few days ago, without adding a new ifdef (just moving the
declaration down into the already existing ifdef below it):
http://marc.info/?l=linux-kernel&m=119311699109698&w=2
-Olof
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Silence radeon_pm warning
2007-10-29 5:02 ` Olof Johansson
@ 2007-10-29 5:33 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2007-10-29 5:33 UTC (permalink / raw)
To: Olof Johansson; +Cc: Ben Herrenschmidt, LKML, linux-fbdev-devel
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Mon, 29 Oct 2007 00:02:02 -0500 Olof Johansson <olof@lixom.net> wrote:
>
> I posted this one a few days ago, without adding a new ifdef (just moving the
> declaration down into the already existing ifdef below it):
>
> http://marc.info/?l=linux-kernel&m=119311699109698&w=2
Yeah, missed that and yours looks better.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-29 5:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-29 2:59 [PATCH] Silence radeon_pm warning Stephen Rothwell
2007-10-29 3:06 ` David Miller
2007-10-29 5:02 ` Olof Johansson
2007-10-29 5:33 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).